From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934518AbdK2RfC (ORCPT ); Wed, 29 Nov 2017 12:35:02 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:55230 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933812AbdK2RfB (ORCPT ); Wed, 29 Nov 2017 12:35:01 -0500 Date: Wed, 29 Nov 2017 17:35:04 +0000 From: Greg Kroah-Hartman To: Joe Perches Cc: SF Markus Elfring , linux-serial@vger.kernel.org, "Guilherme G. Piccoli" , Jiri Slaby , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] jsm_tty: Fix a possible null pointer dereference in two functions Message-ID: <20171129173504.GA20581@kroah.com> References: <5c78db97-88f5-8655-9a47-eeee0a043fba@users.sourceforge.net> <1511976187.19952.65.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1511976187.19952.65.camel@perches.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 29, 2017 at 09:23:07AM -0800, Joe Perches wrote: > On Wed, 2017-11-29 at 17:40 +0100, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Wed, 29 Nov 2017 17:30:36 +0100 > > > > Move two debug messages so that a null pointer access can not happen > > for the variable "ch" in these functions. > > An actual defect fix! Nope, not at all, this does not "fix" anything. > Here you could probably cc stable too. Nope, not worth it. greg k-h