From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752980AbdK2Uz0 (ORCPT ); Wed, 29 Nov 2017 15:55:26 -0500 Received: from mx2.suse.de ([195.135.220.15]:35786 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752499AbdK2UzZ (ORCPT ); Wed, 29 Nov 2017 15:55:25 -0500 Date: Wed, 29 Nov 2017 21:55:23 +0100 From: Jean Delvare To: Vasyl Gomonovych Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] PNP: pnpbios: Use PTR_ERR_OR_ZERO() Message-ID: <20171129215523.47246478@endymion> In-Reply-To: <1511972460-25499-1-git-send-email-gomonovych@gmail.com> References: <1511972460-25499-1-git-send-email-gomonovych@gmail.com> Organization: SUSE Linux X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Nov 2017 17:20:57 +0100, Vasyl Gomonovych wrote: > Fix ptr_ret.cocci warnings: > drivers/pnp/pnpbios/core.c:584:1-3: WARNING: PTR_ERR_OR_ZERO can be used > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > Signed-off-by: Vasyl Gomonovych > --- > drivers/pnp/pnpbios/core.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/pnp/pnpbios/core.c b/drivers/pnp/pnpbios/core.c > index e681140b85d8..077f334fdbae 100644 > --- a/drivers/pnp/pnpbios/core.c > +++ b/drivers/pnp/pnpbios/core.c > @@ -581,10 +581,7 @@ static int __init pnpbios_thread_init(void) > > init_completion(&unload_sem); > task = kthread_run(pnp_dock_thread, NULL, "kpnpbiosd"); > - if (IS_ERR(task)) > - return PTR_ERR(task); > - > - return 0; > + return PTR_ERR_OR_ZERO(task); > } > > /* Start the kernel thread later: */ Looks good to me. Reviewed-by: Jean Delvare -- Jean Delvare SUSE L3 Support