From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753626AbdK3A31 (ORCPT ); Wed, 29 Nov 2017 19:29:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:40984 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752180AbdK3A30 (ORCPT ); Wed, 29 Nov 2017 19:29:26 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B06621906 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=shawnguo@kernel.org Date: Thu, 30 Nov 2017 08:29:06 +0800 From: Shawn Guo To: Yangbo Lu Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mark Rutland , Rob Herring , Russell King Subject: Re: [v2] arm: dts: ls1021a: fix the value of TMR_FIPER1 Message-ID: <20171130002905.GA22908@dragon> References: <20171129065458.4235-1-yangbo.lu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171129065458.4235-1-yangbo.lu@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 29, 2017 at 02:54:58PM +0800, Yangbo Lu wrote: > The timer fixed interval period pulse generator register > is used to generate periodic pulses. The down count > register loads the value programmed in the fixed period > interval (FIPER). At every tick of the timer accumulator > overflow, the counter decrements by the value of > TMR_CTRL[TCLK_PERIOD]. It generates a pulse when the down > counter value reaches zero. It reloads the down counter > in the cycle following a pulse. To use the TMR_FIPER1 > register to generate a 1 PPS event, the value > (10^9 nanoseconds) - TCLK_PERIOD should be programmed. > It should be 999999995 not 999999990 since TCLK_PERIOD > is 5. > > Signed-off-by: Yangbo Lu Again, for arm dts, we usually use prefix like 'ARM: dts: ...' I fixed it up and applied the patch. Shawn > --- > Changes for v2: > - Added Shawn into cc list. > --- > arch/arm/boot/dts/ls1021a.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi > index 64249726b3cb..a861a4b9e319 100644 > --- a/arch/arm/boot/dts/ls1021a.dtsi > +++ b/arch/arm/boot/dts/ls1021a.dtsi > @@ -589,7 +589,7 @@ > fsl,tclk-period = <5>; > fsl,tmr-prsc = <2>; > fsl,tmr-add = <0xaaaaaaab>; > - fsl,tmr-fiper1 = <999999990>; > + fsl,tmr-fiper1 = <999999995>; > fsl,tmr-fiper2 = <99990>; > fsl,max-adj = <499999999>; > }; > -- > 2.14.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel