From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753588AbdK3A0d (ORCPT ); Wed, 29 Nov 2017 19:26:33 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:39288 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752896AbdK3A0c (ORCPT ); Wed, 29 Nov 2017 19:26:32 -0500 X-Auth-Info: yvvauZRtNXKYTf9OEQvW9pxpJ3Ztlh64zCjDhF6guBI= Date: Thu, 30 Nov 2017 01:26:17 +0100 From: Lukasz Majewski To: Alexander Sverdlin Cc: Arnd Bergmann , arndbergmann@gmail.com, Hartley Sweeten , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Olof Johansson , Linus Walleij Subject: Re: [PATCH v2 6/6] ARM: ep93xx: ts72xx: Add support for BK3 board - ts72xx derivative Message-ID: <20171130012617.73ef9cef@jawa> In-Reply-To: <20171129230704.68b5ec42@jawa> References: <20171116232239.16823-1-lukma@denx.de> <20171121143204.1839-1-lukma@denx.de> <20171121143204.1839-7-lukma@denx.de> <86943b7f-be3a-2f41-1ffe-c4d7abfee148@gmail.com> <20171129230704.68b5ec42@jawa> Organization: denx.de X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/OBKesxvF57wv3Y+W0+HUkc3"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/OBKesxvF57wv3Y+W0+HUkc3 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 29 Nov 2017 23:07:04 +0100 Lukasz Majewski wrote: > Hi Alexander, >=20 > > Hello Lukasz, > >=20 > > some nitpicking below... > >=20 > > On 21/11/17 15:32, Lukasz Majewski wrote: =20 > > > The BK3 board is a derivative of the ts72xx reference design. > > >=20 > > > Signed-off-by: Lukasz Majewski > > > --- > > > Changes for v2: > > > - Place bk3 support code to the ts72xx.c file > > > --- > > > arch/arm/mach-ep93xx/Kconfig | 7 +++++ > > > arch/arm/mach-ep93xx/ts72xx.c | 64 > > > +++++++++++++++++++++++++++++++++++++++++++ > > > arch/arm/mach-ep93xx/ts72xx.h | 5 ++++ > > > arch/arm/tools/mach-types | 1 + 4 files changed, 77 > > > insertions(+) > > >=20 > > > diff --git a/arch/arm/mach-ep93xx/Kconfig > > > b/arch/arm/mach-ep93xx/Kconfig index 61a75ca3684e..c095236d7ff8 > > > 100644 --- a/arch/arm/mach-ep93xx/Kconfig > > > +++ b/arch/arm/mach-ep93xx/Kconfig > > > @@ -21,6 +21,13 @@ config MACH_ADSSPHERE > > > Say 'Y' here if you want your kernel to support the ADS > > > Sphere board. > > > =20 > > > +config MACH_BK3 > > > + bool "Support Liebherr BK3.1" > > > + select MACH_TS72XX > > > + help > > > + Say 'Y' here if you want your kernel to support the > > > + Liebherr controller BK3.1. > > > + > > > config MACH_EDB93XX > > > bool > > > =20 > > > diff --git a/arch/arm/mach-ep93xx/ts72xx.c > > > b/arch/arm/mach-ep93xx/ts72xx.c index 2e8fcc6e87b6..0de19b136ad0 > > > 100644 --- a/arch/arm/mach-ep93xx/ts72xx.c > > > +++ b/arch/arm/mach-ep93xx/ts72xx.c > > > @@ -18,8 +18,10 @@ > > > #include > > > #include > > > #include > > > +#include > > > =20 > > > #include > > > +#include > > > =20 > > > #include > > > #include > > > @@ -261,3 +263,65 @@ MACHINE_START(TS72XX, "Technologic Systems > > > TS-72xx SBC") .init_late =3D ep93xx_init_late, > > > .restart =3D ep93xx_restart, > > > MACHINE_END > > > + > > > +/*******************************************************************= ****** > > > + * BK3 support code > > > + > > > *********************************************************************= ****/ > > > +static struct mtd_partition bk3_nand_parts[] =3D { > > > + { > > > + .name =3D "System", > > > + .offset =3D 0x00000000, =20 > >=20 > > I see the above and below lines as unaligned =20 >=20 > This is strange.... I'm using emacs with extension to have coding > style for kernel. >=20 > Probably tabs get unaligned... >=20 > > =20 > > > + .size =3D 0x01e00000, > > > + }, { > > > + .name =3D "Data", > > > + .offset =3D 0x01e00000, =20 > >=20 > > same here > > =20 > > > + .size =3D 0x05f20000 > > > + }, { > > > + .name =3D "RedBoot", > > > + .offset =3D 0x07d20000, =20 > >=20 > > same here > > =20 > > > + .size =3D 0x002e0000, > > > + .mask_flags =3D MTD_WRITEABLE, /* > > > force RO */ > > > + }, > > > +}; > > > + > > > +static AMBA_APB_DEVICE(i2s1, "apb:i2s", 1, EP93XX_I2S_PHYS_BASE, > > > + { IRQ_EP93XX_SAI }, NULL); > > > + > > > +static struct map_desc bk3_io_desc[] __initdata =3D { > > > + { > > > + .virtual =3D BK3_CPLDVER_VIRT_BASE, > > > + .pfn =3D > > > __phys_to_pfn(BK3_CPLDVER_PHYS_BASE), > > > + .length =3D BK3_CPLDVER_SIZE, =20 > >=20 > > same here > > =20 > > > + .type =3D MT_DEVICE, > > > + } > > > +}; > > > + > > > +static void __init bk3_map_io(void) > > > +{ > > > + ts72xx_common_map_io(); > > > + iotable_init(bk3_io_desc, ARRAY_SIZE(bk3_io_desc)); > > > +} > > > + > > > +static void __init bk3_init_machine(void) > > > +{ > > > + ep93xx_init_devices(); > > > + > > > + ts72xx_register_flash(bk3_nand_parts, > > > ARRAY_SIZE(bk3_nand_parts), > > > + EP93XX_CS6_PHYS_BASE); > > > + > > > + platform_device_register(&ts72xx_wdt_device); > > > + ep93xx_register_eth(&ts72xx_eth_data, 1); > > > + > > > + amba_device_register(&i2s1_device, &iomem_resource); > > > +} > > > + > > > +MACHINE_START(BK3, "Liebherr controller BK3.1") > > > + /* Maintainer: Lukasz Majewski */ =20 > >=20 > > Don't you want to add an entry to the MAINTAINERS file instead? > > Then get_maintainer.pl would be able to suggest your email. =20 >=20 > Yes. This would be a good idea (I've followed the "style" of other > boards in the mach-ep93xx directory). >=20 > I will fix that ....... and send v3 with included some extra code - as > I've found and fixed several issues since last posting. >=20 > Anyway, many thanks for review.=20 >=20 > > =20 > > > + .atag_offset =3D 0x100, > > > + .map_io =3D bk3_map_io, =20 > >=20 > > again, inconsistent alignment... =20 >=20 > Even more..... checkpatch.pl did not complained.... I've double checked - this misalignment seems to be only in e-mail. In the ts72xx.c file it is all "tabifi'ed". (and no checkpatch errors). >=20 > > =20 > > > + .init_irq =3D ep93xx_init_irq, > > > + .init_time =3D ep93xx_timer_init, > > > + .init_machine =3D bk3_init_machine, > > > + .init_late =3D ep93xx_init_late, > > > + .restart =3D ep93xx_restart, > > > +MACHINE_END > > > diff --git a/arch/arm/mach-ep93xx/ts72xx.h > > > b/arch/arm/mach-ep93xx/ts72xx.h index d9ff04db3221..d3165bb9ee78 > > > 100644 --- a/arch/arm/mach-ep93xx/ts72xx.h > > > +++ b/arch/arm/mach-ep93xx/ts72xx.h > > > @@ -45,6 +45,11 @@ > > > #define TS72XX_WDT_CONTROL_PHYS_BASE 0x23800000 > > > #define TS72XX_WDT_FEED_PHYS_BASE 0x23c00000 > > > =20 > > > +/* BK3 specific defines */ > > > +#define BK3_CPLDVER_PHYS_BASE 0x23400000 > > > +#define BK3_CPLDVER_VIRT_BASE 0xfebfd000 > > > +#define BK3_CPLDVER_SIZE 0x00001000 > > > + > > > #ifndef __ASSEMBLY__ > > > =20 > > > static inline int ts72xx_model(void) > > > diff --git a/arch/arm/tools/mach-types b/arch/arm/tools/mach-types > > > index a9313b66f770..4eac94c1eb6f 100644 > > > --- a/arch/arm/tools/mach-types > > > +++ b/arch/arm/tools/mach-types > > > @@ -345,6 +345,7 @@ mxlads > > > MACH_MXLADS MXLADS 1851 > > > linkstation_mini MACH_LINKSTATION_MINI > > > LINKSTATION_MINI 1858 afeb9260 > > > MACH_AFEB9260 AFEB9260 1859 > > > imx27ipcam MACH_IMX27IPCAM > > > IMX27IPCAM 1871 +bk3 > > > MACH_BK3 BK3 1880 > > > rd88f6183ap_ge MACH_RD88F6183AP_GE > > > RD88F6183AP_GE 1894 realview_pba8 > > > MACH_REALVIEW_PBA8 REALVIEW_PBA8 1897 > > > realview_pbx MACH_REALVIEW_PBX > > > REALVIEW_PBX 1901 =20 >=20 >=20 >=20 > Best regards, >=20 > Lukasz Majewski >=20 > -- >=20 > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de --Sig_/OBKesxvF57wv3Y+W0+HUkc3 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAlofUCkACgkQAR8vZIA0 zr0ATAgAgIp9OW8Aj6cfhSa91EZmVdFcD6y3OzFvdgr93TP/qZLmK2AawFPtgcFD hBrTYete7aDomSYqDi9vn7vdjlUCDpXAvbEjMwg9ehZIhXwXX5dpI3cwzVWjwvIG UDQ99NBHI+YKc2JpMnyQuDd7h4wRvW1SWfZdejVjCUm3hrEchkdK0qm5CheMiEze A2id+HPS8WTTI/XVbjRI6U/LYJ2YbN8yGOWTqVWTuFxQWLgMW/mNYnnR3QZJHeU+ xdSeu9zEk3oUFBAx4iQKAWKJRCaj6bBcaM3MbDesnf/VB8HJ1AWsish2sJbcFhsp drtnY9nFnRaC+uiTKOz7n/J/pdz6Gg== =A8H9 -----END PGP SIGNATURE----- --Sig_/OBKesxvF57wv3Y+W0+HUkc3--