Re: [PATCH V11 2/5] vsprintf: refactor %pK code out of pointer()

Tobin C. Harding
2017-11-29T04:27:52Z

On Tue, Nov 28, 2017 at 09:39:57PM -0500, Steven Rostedt wrote:
> On Wed, 29 Nov 2017 13:05:02 +1100
> "Tobin C. Harding" <me@tobin.cc> wrote:
>
> > + /*
> > + * kptr_restrict==1 cannot be used in IRQ context
> > + * because its test for CAP_SYSLOG would be meaningless.
> > + */
> > + if (in_irq() || in_serving_softirq() || in_nmi())
>
> This could be replaced with:
>
> if (!in_task())
>
> Which is actually more efficient.

thanks for the comment Steve. At this late stage in the game do you mind
if I don't include this change in this set. The code line in question is
only in the series because of refactoring. I'm comfortable arguing that
improving efficiency is out of scope ;)

thanks,
Tobin.