From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752339AbdK3JSD (ORCPT ); Thu, 30 Nov 2017 04:18:03 -0500 Received: from mga01.intel.com ([192.55.52.88]:3832 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751354AbdK3JR7 (ORCPT ); Thu, 30 Nov 2017 04:17:59 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,341,1508828400"; d="scan'208";a="13684321" Date: Thu, 30 Nov 2017 14:51:31 +0530 From: Vinod Koul To: Geert Uytterhoeven Cc: Benjamin Gaignard , Dan Williams , Maxime Coquelin , Alexandre Torgue , dmaengine@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Benjamin Gaignard , "M'boumba Cedric Madianga" Subject: Re: [PATCH v2] dma: stm32: Fix copyright Message-ID: <20171130092130.GV32417@localhost> References: <20171130084249.23196-1-benjamin.gaignard@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 30, 2017 at 09:49:34AM +0100, Geert Uytterhoeven wrote: > Hi Benjamin, > > On Thu, Nov 30, 2017 at 9:42 AM, Benjamin Gaignard > wrote: > > Uniformize STMicroelectronics copyrights header > > Add SPDX identifier > > > > Signed-off-by: Benjamin Gaignard > > Acked-by: Alexandre TORGUE > > CC: M'boumba Cedric Madianga > > --- > > drivers/dma/stm32-dma.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/dma/stm32-dma.c b/drivers/dma/stm32-dma.c > > index 786fc8fcc38e..e3187ee9afe9 100644 > > --- a/drivers/dma/stm32-dma.c > > +++ b/drivers/dma/stm32-dma.c > > @@ -1,12 +1,13 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > /* > > * Driver for STM32 DMA controller > > * > > * Inspired by dma-jz4740.c and tegra20-apb-dma.c > > * > > * Copyright (C) M'boumba Cedric Madianga 2015 > > + * Copyright (C) STMicroelectronics 2017 > > According to git history, this file wasn't modified by STM in 2017? or rather ever.. File has 14 non merge commits, 9 from M'boumba Cedric Madianga, 1 from Colin Ian King and rest yours truely. IANAL but changing copyright here does sound fishy.. what's going on? > > > * Author: M'boumba Cedric Madianga > > * > > - * License terms: GNU General Public License (GPL), version 2 > > */ > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- ~Vinod