From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753474AbdK3ChC (ORCPT ); Wed, 29 Nov 2017 21:37:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:52880 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752734AbdK3ChA (ORCPT ); Wed, 29 Nov 2017 21:37:00 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A935221986 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=mhiramat@kernel.org Date: Thu, 30 Nov 2017 11:36:57 +0900 From: Masami Hiramatsu To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 06/12] perf, tools, probe: Support a quiet argument for debug info open Message-Id: <20171130113657.65a50277f9bafdaaae488cf9@kernel.org> In-Reply-To: <20171129033943.GA2482@two.firstfloor.org> References: <20171128002321.2878-1-andi@firstfloor.org> <20171128002321.2878-7-andi@firstfloor.org> <20171129121400.9ded2948615eaaf110bbec7e@kernel.org> <20171129033943.GA2482@two.firstfloor.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Nov 2017 19:39:43 -0800 Andi Kleen wrote: > On Wed, Nov 29, 2017 at 12:14:00PM +0900, Masami Hiramatsu wrote: > > On Mon, 27 Nov 2017 16:23:15 -0800 > > Andi Kleen wrote: > > > > > From: Andi Kleen > > > > > > Add a extra quiet argument to the debug info open / probe finder > > > code that allows perf script to make them quieter. Otherwise > > > we may end up with too many error messages when lots of > > > instructions fail debug info parsing. > > > > IMHO, this kind of simple suppress warning message would better > > be done with pr_* implementation (or its macro) since there > > maybe new message added or other function which has warning > > messages can be called in the future. > > Do you really mean adding a special pr_ / global just for this case? I thought that we could control it by changing "verbose" global variables. Something like inc_verbose() & dec_verbose() macros will help us to suppress warning/debug messages temporary. Thank you, > > Seems less clean to me, but I can do it. > > -Andi -- Masami Hiramatsu