From: Josh Abraham <j.abraham1776@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: arnaud.patard@rtp-net.org, kstewart@linuxfoundation.org,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, pombredanne@nexb.com,
tglx@linutronix.de
Subject: Re: [PATCH] staging: xgifb: remove unused macro XGIPART3
Date: Thu, 30 Nov 2017 07:52:42 -0500 [thread overview]
Message-ID: <20171130125242.GA20957@josharch> (raw)
In-Reply-To: <20171130055544.zumzsypzwzssozts@mwanda>
On Thu, Nov 30, 2017 at 08:55:44AM +0300, Dan Carpenter wrote:
> On Wed, Nov 29, 2017 at 09:53:48PM -0500, Joshua Abraham wrote:
> > Signed-off-by: Joshua Abraham <j.abraham1776@gmail.com>
> >
> > This patch removes the unused macro XGIPART3.
> >
>
> The Signed-off-by line goes after the changelog.
>
> > ---
> > drivers/staging/xgifb/XGI_main.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/staging/xgifb/XGI_main.h b/drivers/staging/xgifb/XGI_main.h
> > index a3af1cbbf8ee..5f55d0a39bc1 100644
> > --- a/drivers/staging/xgifb/XGI_main.h
> > +++ b/drivers/staging/xgifb/XGI_main.h
> > @@ -25,7 +25,6 @@ MODULE_DEVICE_TABLE(pci, xgifb_pci_table);
> > #define XGIDACD (xgifb_info->dev_info.P3c9)
> > #define XGIPART1 (xgifb_info->dev_info.Part1Port)
> > #define XGIPART2 (xgifb_info->dev_info.Part2Port)
> > -#define XGIPART3 (xgifb_info->dev_info.Part3Port)
>
> That define isn't hurting anyone.
>
> > #define XGIPART4 (xgifb_info->dev_info.Part4Port)
> > #define XGIPART5 (xgifb_info->dev_info.Part5Port)
>
> Actually these should all be deleted because they mean you have to have
> a xgifb_info variable and they hurt readability by hiding stuff behind a
> define. It would be better to remove them all than to just remove one
> from the middle. That's a more complicated patch, but it's a useful
> patch.
>
> regards,
> dan carpenter
>
Great point. I will work on that and get the patch out!
-Josh
prev parent reply other threads:[~2017-11-30 12:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 2:53 [PATCH] staging: xgifb: remove unused macro XGIPART3 Joshua Abraham
2017-11-30 5:55 ` Dan Carpenter
2017-11-30 12:52 ` Josh Abraham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130125242.GA20957@josharch \
--to=j.abraham1776@gmail.com \
--cc=arnaud.patard@rtp-net.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).