From: Serge Semin <fancer.lancer@gmail.com>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: jdmason@kudzu.us, dave.jiang@intel.com, Allen.Hubbe@emc.com,
Shyam-sundar.S-k@amd.com, Xiangliang.Yu@amd.com,
Sergey.Semin@t-platforms.ru, linux-ntb@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/08] NTB: ntb_test: Safely use paths with whitespace
Date: Fri, 1 Dec 2017 01:12:58 +0300 [thread overview]
Message-ID: <20171130221258.GA20562@mobilestation> (raw)
In-Reply-To: <923625e8-f071-c9f6-a3e2-c16480d4aea6@deltatee.com>
On Thu, Nov 30, 2017 at 03:04:29PM -0700, Logan Gunthorpe <logang@deltatee.com> wrote:
Hello
> Hey,
>
> I took a cursory look at this series and it largely looks good to me. Nice
> work. If I have time in the next couple days I'll do a more thorough review.
> However, does the series not depend on changes to ntb_tool? It would have
> been good to include a cover letter describing the intention/plan.
>
In general the intention of the patchset was to update the ntb_test.sh script
so one would be compatible with new NTB test drivers I've also sent. It was
asked of me by the NTB core maintainers. Sorry for not mentioning it in the
cover letter.
-Sergey
>
> On 30/11/17 02:42 PM, Serge Semin wrote:
> >If some of variables like LOC/REM or LOCAL_*/REMOTE_* got
> >whitespaces, the script may fail with syntax error.
> >
> >Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
>
> Seeing this is a bug fix I Ack Patch 1 and suggest it get merged ahead of
> the series.
>
> Acked-by: Logan Gunthorpe <logang@deltatee.com>
> Fixes: a9c59ef77458 ("ntb_test: Add a selftest script for the NTB
> subsystem")
>
> Thanks for the fix.
>
> Logan
>
> --
> You received this message because you are subscribed to the Google Groups "linux-ntb" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-ntb+unsubscribe@googlegroups.com.
> To post to this group, send email to linux-ntb@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/linux-ntb/923625e8-f071-c9f6-a3e2-c16480d4aea6%40deltatee.com.
> For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2017-11-30 22:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 21:42 [PATCH 01/08] NTB: ntb_test: Safely use paths with whitespace Serge Semin
2017-11-30 21:42 ` [PATCH 02/08] NTB: ntb_test: Add ntb_tool port tests Serge Semin
2017-11-30 22:37 ` Logan Gunthorpe
2017-11-30 21:42 ` [PATCH 03/08] NTB: ntb_test: Update ntb_tool link tests Serge Semin
2017-11-30 21:42 ` [PATCH 04/08] NTB: ntb_test: Update ntb_tool DB tests Serge Semin
2017-11-30 21:42 ` [PATCH 05/08] NTB: ntb_test: Update ntb_tool Scratchpad tests Serge Semin
2017-11-30 21:42 ` [PATCH 06/08] NTB: ntb_test: Add ntb_tool Message tests Serge Semin
2017-11-30 21:42 ` [PATCH 07/08] NTB: ntb_test: Update ntb_tool MW tests Serge Semin
2017-11-30 21:43 ` [PATCH 08/08] NTB: ntb_test: Update ntb_perf tests Serge Semin
2017-11-30 22:04 ` [PATCH 01/08] NTB: ntb_test: Safely use paths with whitespace Logan Gunthorpe
2017-11-30 22:12 ` Serge Semin [this message]
2017-11-30 22:26 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130221258.GA20562@mobilestation \
--to=fancer.lancer@gmail.com \
--cc=Allen.Hubbe@emc.com \
--cc=Sergey.Semin@t-platforms.ru \
--cc=Shyam-sundar.S-k@amd.com \
--cc=Xiangliang.Yu@amd.com \
--cc=dave.jiang@intel.com \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=logang@deltatee.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox