From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752197AbdLAJuE (ORCPT ); Fri, 1 Dec 2017 04:50:04 -0500 Received: from mga03.intel.com ([134.134.136.65]:9425 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751848AbdLAJuC (ORCPT ); Fri, 1 Dec 2017 04:50:02 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,344,1508828400"; d="scan'208";a="11806171" Date: Fri, 1 Dec 2017 11:49:58 +0200 From: "mika.westerberg@linux.intel.com" To: "Bernat, Yehezkel" Cc: "andreas.noever@gmail.com" , "linux-kernel@vger.kernel.org" , "Jamet, Michael" Subject: Re: [PATCH 2/2] thunderbolt: Mask ring interrupt properly when polling starts Message-ID: <20171201094958.GL22431@lahna.fi.intel.com> References: <20171127114858.20893-1-mika.westerberg@linux.intel.com> <20171127114858.20893-2-mika.westerberg@linux.intel.com> <1511799651.2950.4.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1511799651.2950.4.camel@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 27, 2017 at 04:21:34PM +0000, Bernat, Yehezkel wrote: > On Mon, 2017-11-27 at 14:48 +0300, Mika Westerberg wrote: > > When ring enters polling mode we are expected to mask the ring > > interrupt > > before the callback is called. However, the current code actually > > unmasks it probably because of a copy-paste mistake. > > > > Mask the interrupt properly from now on. > > > > Fixes: 4ffe722eefcb ("thunderbolt: Add polling mode for rings") > > Signed-off-by: Mika Westerberg > > --- > >  drivers/thunderbolt/nhi.c | 2 +- > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c > > index 419a7a90bce0..f45bcbc63738 100644 > > --- a/drivers/thunderbolt/nhi.c > > +++ b/drivers/thunderbolt/nhi.c > > @@ -339,7 +339,7 @@ static void __ring_interrupt(struct tb_ring > > *ring) > >   return; > >   > >   if (ring->start_poll) { > > - __ring_interrupt_mask(ring, false); > > + __ring_interrupt_mask(ring, true); > >   ring->start_poll(ring->poll_data); > >   } else { > >   schedule_work(&ring->work); > > Acked-by: Yehezkel Bernat Applied with Yehezkel's ACK.