From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752859AbdLANQT (ORCPT ); Fri, 1 Dec 2017 08:16:19 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:58910 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752001AbdLANQP (ORCPT ); Fri, 1 Dec 2017 08:16:15 -0500 Date: Fri, 1 Dec 2017 13:15:38 +0000 From: Roman Gushchin To: Michal Hocko CC: , Vladimir Davydov , Johannes Weiner , Tetsuo Handa , David Rientjes , Andrew Morton , Tejun Heo , , , , , Subject: Re: [PATCH v13 5/7] mm, oom: add cgroup v2 mount option for cgroup-aware OOM killer Message-ID: <20171201131530.GA7741@castle.DHCP.thefacebook.com> References: <20171130152824.1591-1-guro@fb.com> <20171130152824.1591-6-guro@fb.com> <20171201084113.47lnuo3diwxts732@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20171201084113.47lnuo3diwxts732@dhcp22.suse.cz> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [2620:10d:c092:200::1:f2c] X-ClientProxiedBy: VI1PR0102CA0089.eurprd01.prod.exchangelabs.com (2603:10a6:803:15::30) To DM3PR15MB1082.namprd15.prod.outlook.com (2603:10b6:0:12::8) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7a1bca29-8958-433d-0221-08d538bda5e3 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603286);SRVR:DM3PR15MB1082; X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB1082;3:iDi/s1n0K5CvSV65vReDIsJIBoraa0T7KDqU9rVR7jQh4LHGIec23he2fZEYvkuDBY0dfqhBgjxVXsgSs9/u41dl5E4lxhHAEcaaxKhnqdxCc5O/rm4xA4sdgrW2DIvIqCxXc9JQs2eHdwHrnxHxWli0asAvXqvwTjHTTIQD5Tr7dWCnFUf2wOwbQMDkPoZH7uScoLWUm5lbR93ckk6ybBBWHWd2bFC4ilzSDHX5od+9xC9XPIS19JpBlinXV6Zy;25:nDMALsgIVSgSr+CLQx+puYKbHDAPHhpe9DRCnQNgv7rIBaFlmDzsQm+f80U8JUcCPUeheYGg3rgfr7OULfsbZHbM8qLpH2slQ44n5L8o2LfMRU1QvPaMfhc90YjFZNw755tL9jijN4XO0+CabFjjhWph1JflbxXlGU5LyAR/S2l6YjmmAO+cn37UDYaAMbJ+5pIdQ11+sZVYT0FnNGZc1f5c+YsYlpdg0dQpsCyqr9n5qiBb4wtlPLYooqQU0i9ygwicAcWQ5tUVwHpvMAvLANXDDFYE8RMBu6C+cgotLYXEGzA0DDNEVrMLEfbiegKwZTRHliKb2C9b7YyNwtUC1Q==;31:rnf/E5/f4+XSbtH1vtahaqsEMfIscR26HpajKYCEwr4kP7lGXSLjeWqcoj5QTIROadSFMHS+qQLjf2W0U7mAE0ABvRAxecO5rZ3fnB6Qgj9zycPMeOMNLTcBjhdvHy+XMetP8d8vmu/czcFB+eZn0taiNM1lRicrK5Xim0V36RPYHVuVNW9M/cF1Bl8NcOX/uxCL4yJh2TPFSUJJGiyWAjHTXMaLuhMBhC5xuDqlaZ0= X-MS-TrafficTypeDiagnostic: DM3PR15MB1082: X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB1082;20:iLkHdx/rZ7VqhEwGIdRS30691gOxCf6UG8QL1+Yft7ki8Hr+NBm5c325ZLs1vdPQiP9wvEPfZNkUFNwuMLT6FyGRdn60JDVGF+Ubpv8UoVYEkq2sHx1N5wSpBWFkYTwe+wd4CBhwcnlO0luE5RuAM4SIUpGy0FJhDfIDGQQiETIO4o5VnoIrbldoEoffbNsIvSsP+zGmFXAD+gB4ZLiyTYW3IcElMTPxe3kI9SRBrEXaz95LLJJmzIPkEbuYJ/+haKYRykVeEwLz+Zk1MQS1kx7MGKiEY5iFsgKFVDdRWlwE+uIpe9leghXhCMjdG7QxxJkVvaA3wkp44c5ZZhmjTjoxY/b6mOXHjE8C3gNyGEFco15sxny5Y5ZQBK//bc3bJ2/HEfrVIZr26NOOF67WWCw+LoFlu39KHN0DO/dmRrVGJFq4f91pEkxmUTnHL3MiCc7hb/w8sXSSU6AhtqZNvVzhsNobMxvGZ5zMhyTeB7H5AgrMVxFZMBZyr3mF5Ubb;4:ws1vhe563PmLh1T9ch2yaizJGUCk8izkwExXtz/07KEEetvvTojIyMuS/IWpZgXYHK6clSYebH4b4vwusC/aPfFxQdWx0VNmwk/o7lHSjxmIwDiUHKV1IlEzIZMht+9aiTAHx1tIywdNrclC71fn+OCRqMweEUCMrLbK/djajS7PuPtPmmvIoPZhuECfDfjXble4Gjh+Q4RIht0VjS4aHh1kbkQNmfwA4/0dNoZ4jRTKlFACzzlq741BY/eVE1HzPWUDlZZWhXowaphmcru30A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(11241501159)(6040450)(2401047)(8121501046)(5005006)(3002001)(3231022)(10201501046)(93006095)(93001095)(6041248)(20161123560025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123564025)(6072148)(201708071742011);SRVR:DM3PR15MB1082;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:DM3PR15MB1082; X-Forefront-PRVS: 05087F0C24 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(366004)(376002)(346002)(24454002)(377424004)(189002)(199003)(52396003)(106356001)(229853002)(97736004)(33656002)(105586002)(1076002)(23726003)(6246003)(54356011)(76176011)(101416001)(6116002)(6506006)(50466002)(53936002)(2906002)(478600001)(47776003)(6916009)(7696005)(16586007)(8676002)(9686003)(81156014)(52116002)(7736002)(86362001)(2950100002)(6666003)(55016002)(83506002)(81166006)(305945005)(189998001)(68736007)(25786009)(4326008)(5660300001)(58126008)(39060400002)(54906003)(8936002)(316002)(7416002)(18370500001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM3PR15MB1082;H:castle.DHCP.thefacebook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM3PR15MB1082;23:/7zp2wA5abjZ9To66w6yBYl+2omrvIHywYZ3FSROF?= =?us-ascii?Q?41z1cLg2JB15+X5JNgU/ODlE2Sq42iv1jN3i8WA/M2IPnuUiaFlrEYGgrPnh?= =?us-ascii?Q?CQKoUEefRcYxXD8UaQ13A2hd0DnIToNOblAp2tV7flQLdFvbcons9uZsuWMx?= =?us-ascii?Q?f0IPTfZ2FFEUrkLR+lr59zd/WcZ663thnaccF5yodKJW2HecMSn0YUsi3CoS?= =?us-ascii?Q?FUgXOZa8NNGsjWICQm8mBn9i5KqE8GEuPh2j0EVBYzvSL+2wgvB6wj5jHoDw?= =?us-ascii?Q?97u0qNkgwD88Gz6ohF3lY3PpZdzb4yBzqNy7gyUigGJwcujx6B8/ZVUx/yQL?= =?us-ascii?Q?KUfqW6lgMsZtYKkTrpRW+UWeyJkGrZbz5K/MC1J6BuvuU46rMQv+mrFpkVAh?= =?us-ascii?Q?Hr9YKcBtrZyY9zF32DmpVwhwMrkQihLshe0bAQDmj2lJAaCMf1ONiU5/scza?= =?us-ascii?Q?xJxZ46C86PvIvDGlz9WtsNrqw1S9yufmAVQJpXfr1sJ5PIYVDzpCDbkAI4JM?= =?us-ascii?Q?g5XFyp/Sceduml7Spxz9nQqQumvvP8MN73u19IFzjJkT3VjNasV/CAXMNhPO?= =?us-ascii?Q?A5vIqdv+jM3PSAZ+T8gKbnwqEvmBkY6HnSohUb2It1GnarIsJvDnx095S+th?= =?us-ascii?Q?D1PTinnCPqs5javlqmM+2oDT9UNsKwjwbI/TFXuVXw2BkfPyPIoVtHRRq5vG?= =?us-ascii?Q?DR5zAroaodylpnGBI8bT3Sqfkf2j8wK5eICxdbg0TLm/WZLjjG6QypzEOJGm?= =?us-ascii?Q?b12Yt3jQy56hMKJleUlpmA2hevrlppkUJmCCHf+I08RcRBHXwdGkQAolZTVB?= =?us-ascii?Q?qtjcso7kBPpgtK4IQe+JMyOfYaUh+xICjdkETt6HNzdEuN484l95ZQvvLqYw?= =?us-ascii?Q?lk/LFfAA1CfchBUaS5oCWV01wC0+LmK3Nh3EOCfSO34eeucYPTruVGXEwpR3?= =?us-ascii?Q?eTDz/xAKzBpFGEVFdfqjldQLeOCOcaVS9nkjxk8pBNvn6c1csCv53gO6sovu?= =?us-ascii?Q?WZr5+iWCznd9m+16VuaIrgWjAb1DkbrUQRd6ESpJHkCFKVtazAMXErz1BZk8?= =?us-ascii?Q?PReVy7KQnCCS5wKd735Khpzm6MOiBtwM3Lb+cCAL2Sr0mTCYf9DVATfNTQLN?= =?us-ascii?Q?pV1Z9tHTqDYzQKXIMVhnvAWU4UQLNCyMdiJWCtOf9WoWptBIsr3CzqhPSWBW?= =?us-ascii?Q?nGSQLLGvVbO77/SCp0nS9z29kbbZakixHy8y+6IAcvKDQilQg+Eb+dUFSq1x?= =?us-ascii?Q?3TuGGXTN2TwUF8yjz/Ew/lhCaPCipniR261E2qf?= X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB1082;6:Ijet61tgcNX7OoAPTtXOENDPK9Ap6z1pmM9m7pIDmGERULQJm+wX2JWtOVZyoX0Qp9DXnekV6uIBqK65eFvxkDf1Vp9kaRBqzsxkc0MjRB5KSxDXxgfJZ8/pQJUJ6KrWo/WisoFuBi0DtgYWzasqLxqOpLG5HUg/WfsixNMuRW0umRTPdtkPp9moog80MRmI2JL+5EMANfM7tDLaQVQvdQE4o1+U4OQX1w89xiAuLtx4rlxzwlSvLQbOCm21JYb0YfAOjl9ybaxOTNbdBiojXb5VE28DqI56HiQ1prlNFCWTXYaZr0PBX0B5Ctm6dKX0s/1wBqxam7++WODhTsT0QfyW+S4i7tSv/MReDULsD7k=;5:E3Tz/hrlvC8VcZsM5Ee5h3qGG15koCBUzJfndP3kKXnX5W64GMjxtRZCo0ZhoA+PK851yGW2yyrc0e4UnVmdVIiJKid4r1WTj6WWsgh193p12w3XAxniOXXl+gVZssXIk1quG91MnI/tKLTm8SIVq4cGREpvsVoQOElnIz0mgfI=;24:1IuwQdX0iBH5wXxX7cFOtrLk107PQ5jMpXeEiQNVWAaSfyXrdf8Wp95XFUM+IMBIDaHxQdqwsQ+4CV7g06NzUqY83zuRdggzOw1K8gqOuvI=;7:RZD49GzhSsFISCV1YCT2AOQVFY/G8wXunitIrSVbZwJXJWW1v8lrbvMFl6nOHglsbT4XYMoTfFHkLAkwL63H7n2CcEgyogHkmiFub4yGeENG4v4IuDIcdqa12L1GiX8aifbDdRHi4V1psSYzUH4RksGJiO2SqERu1HMxA7jk1TyrhHYw/6ExWWiSe39nSOQBQsyJyaY04rAFSBsANEyIs2UZNHDFI9FGWx7FD4/29dlYLRg2VHMdNLSYS/X1rkVG SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB1082;20:v8cxOwG+Lw1Ts5Go3Hoygp++O4mBLLI/5mb0t7eoZSdPV+QSV/jRwfrNYtCgUzk0KNxQtYyfglPYuFFhNLDJhgRj0gHTtXu3zHa5N+UPlnxDkvYG/PFAGfrmFaKT9I4esOGM4fRst8QkyRn1mJpoRXQGSuAnx65ZsCeN3AyDteo= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2017 13:15:50.1509 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7a1bca29-8958-433d-0221-08d538bda5e3 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR15MB1082 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-01_03:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 01, 2017 at 09:41:13AM +0100, Michal Hocko wrote: > On Thu 30-11-17 15:28:22, Roman Gushchin wrote: > > Add a "groupoom" cgroup v2 mount option to enable the cgroup-aware > > OOM killer. If not set, the OOM selection is performed in > > a "traditional" per-process way. > > > > The behavior can be changed dynamically by remounting the cgroupfs. > > Is it ok to create oom_group if the option is not enabled? This looks > confusing. I forgot all the details about how cgroup core creates file > so I do not have a good idea how to fix this. I don't think we do show/hide interface files dynamically. Even for things like socket memory which can be disabled by the boot option, we don't hide the corresponding stats entry. So, maybe we just need to return -EAGAIN (or may be -ENOTSUP) on any read/write attempt if option is not enabled? Thanks!