From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752940AbdLAOO4 (ORCPT ); Fri, 1 Dec 2017 09:14:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:49044 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752605AbdLAOOy (ORCPT ); Fri, 1 Dec 2017 09:14:54 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A820218B2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Fri, 1 Dec 2017 11:14:52 -0300 From: Arnaldo Carvalho de Melo To: Andi Kleen Cc: Jin Yao , jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v5 04/12] perf util: Add rbtree node_delete ops Message-ID: <20171201141452.GX3298@kernel.org> References: <1512125856-22056-1-git-send-email-yao.jin@linux.intel.com> <1512125856-22056-5-git-send-email-yao.jin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1512125856-22056-5-git-send-email-yao.jin@linux.intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Dec 01, 2017 at 06:57:28PM +0800, Jin Yao escreveu: > @@ -130,7 +140,7 @@ void perf_stat__init_shadow_stats(void) > rblist__init(&runtime_saved_values); > runtime_saved_values.node_cmp = saved_value_cmp; > runtime_saved_values.node_new = saved_value_new; > - /* No delete for now */ > + runtime_saved_values.node_delete = saved_value_delete; > } Andi, was some reason behind that comment, is it safe to add it now? - Arnaldo