From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752073AbdLAS3k (ORCPT ); Fri, 1 Dec 2017 13:29:40 -0500 Received: from one.firstfloor.org ([193.170.194.197]:38924 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750872AbdLAS3j (ORCPT ); Fri, 1 Dec 2017 13:29:39 -0500 Date: Fri, 1 Dec 2017 10:29:37 -0800 From: Andi Kleen To: Arnaldo Carvalho de Melo Cc: Andi Kleen , Jin Yao , jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v5 04/12] perf util: Add rbtree node_delete ops Message-ID: <20171201182936.GC2482@two.firstfloor.org> References: <1512125856-22056-1-git-send-email-yao.jin@linux.intel.com> <1512125856-22056-5-git-send-email-yao.jin@linux.intel.com> <20171201141452.GX3298@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171201141452.GX3298@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 01, 2017 at 11:14:52AM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Dec 01, 2017 at 06:57:28PM +0800, Jin Yao escreveu: > > @@ -130,7 +140,7 @@ void perf_stat__init_shadow_stats(void) > > rblist__init(&runtime_saved_values); > > runtime_saved_values.node_cmp = saved_value_cmp; > > runtime_saved_values.node_new = saved_value_new; > > - /* No delete for now */ > > + runtime_saved_values.node_delete = saved_value_delete; > > } > > Andi, was some reason behind that comment, is it safe to add it now? It is safe to add.