The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@mellanox.com>
To: Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@redhat.com>
Cc: Jesper Dangaard Brouer <brouer@redhat.com>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH] bpf: Fix compile warnings when !CONFIG_BPF_SYSCALL
Date: Fri, 1 Dec 2017 12:06:05 -0700	[thread overview]
Message-ID: <20171201190605.GA21174@ziepe.ca> (raw)

Such as:

In file included from ./include/trace/events/xdp.h:10:0,
                 from ./include/linux/bpf_trace.h:6,
                 from drivers/net/ethernet/intel/i40e/i40e_txrx.c:29:
./include/trace/events/xdp.h:94:17: warning: ‘struct bpf_map’ declared inside parameter list
    const struct bpf_map *map, u32 map_index),
                 ^

By adding a forward declaration for struct bpf_map. In the
CONFIG_BPF_SYSCALL case the declaration comes in via
trace/events/bpf.h

Fixes: 59a308967589 ("xdp: separate xdp_redirect tracepoint in map case")
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
---
 include/trace/events/xdp.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/trace/events/xdp.h b/include/trace/events/xdp.h
index 4cd0f05d01134d..36b2a9043189be 100644
--- a/include/trace/events/xdp.h
+++ b/include/trace/events/xdp.h
@@ -9,6 +9,8 @@
 #include <linux/filter.h>
 #include <linux/tracepoint.h>
 
+struct bpf_map;
+
 #define __XDP_ACT_MAP(FN)	\
 	FN(ABORTED)		\
 	FN(DROP)		\
-- 
2.7.4

             reply	other threads:[~2017-12-01 19:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01 19:06 Jason Gunthorpe [this message]
2017-12-01 19:32 ` [PATCH] bpf: Fix compile warnings when !CONFIG_BPF_SYSCALL Daniel Borkmann
2017-12-01 19:48 ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171201190605.GA21174@ziepe.ca \
    --to=jgg@mellanox.com \
    --cc=brouer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox