From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752079AbdLBABe (ORCPT ); Fri, 1 Dec 2017 19:01:34 -0500 Received: from mail-it0-f51.google.com ([209.85.214.51]:43739 "EHLO mail-it0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751859AbdLBABc (ORCPT ); Fri, 1 Dec 2017 19:01:32 -0500 X-Google-Smtp-Source: AGs4zMZVHPL6jzOwNjvECE9yvmEpb2bXTq4BOHTNo7AIgw15jqh+5vq50RmN7o5pxQWzqbETdgSBnA== Date: Fri, 1 Dec 2017 17:01:30 -0700 From: Jason Gunthorpe To: Geert Uytterhoeven Cc: Yuval Shaia , Doug Ledford , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: IB: INFINIBAND should depend on HAS_DMA Message-ID: <20171202000130.GB20454@ziepe.ca> References: <1511117910-25003-1-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1511117910-25003-1-git-send-email-geert@linux-m68k.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 19, 2017 at 07:58:30PM +0100, Geert Uytterhoeven wrote: > If NO_DMA=y: > > ERROR: "bad_dma_ops" [net/sunrpc/xprtrdma/rpcrdma.ko] undefined! > ERROR: "bad_dma_ops" [net/smc/smc.ko] undefined! > ERROR: "bad_dma_ops" [net/rds/rds_rdma.ko] undefined! > ERROR: "bad_dma_ops" [net/9p/9pnet_rdma.ko] undefined! > ERROR: "bad_dma_ops" [drivers/nvme/target/nvmet-rdma.ko] undefined! > ERROR: "bad_dma_ops" [drivers/nvme/host/nvme-rdma.ko] undefined! > ERROR: "bad_dma_ops" [drivers/infiniband/ulp/srpt/ib_srpt.ko] undefined! > ERROR: "bad_dma_ops" [drivers/infiniband/ulp/srp/ib_srp.ko] undefined! > ERROR: "bad_dma_ops" [drivers/infiniband/ulp/isert/ib_isert.ko] undefined! > ERROR: "bad_dma_ops" [drivers/infiniband/ulp/iser/ib_iser.ko] undefined! > ERROR: "bad_dma_ops" [drivers/infiniband/ulp/ipoib/ib_ipoib.ko] undefined! > ERROR: "bad_dma_ops" [drivers/infiniband/core/ib_core.ko] undefined! > > Before, this was handled implicitly by the dependency on PCI. > Add an explicit dependency on HAS_DMA to fix this. > > Fixes: 931bc0d91639f8fb ("IB: Move PCI dependency from root KConfig to HW's KConfigs") > Signed-off-by: Geert Uytterhoeven > Reviewed-by: Leon Romanovsky > drivers/infiniband/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to for-rc, thanks Jason