From: Greg KH <gregkh@linuxfoundation.org>
To: Marcus Wolf <linux@wolf-entwicklungen.de>
Cc: dan.carpenter@oracle.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: pi433: Bugfix for shift operation in rf69_get_modulation()
Date: Sat, 2 Dec 2017 14:58:43 +0000 [thread overview]
Message-ID: <20171202145843.GB1242@kroah.com> (raw)
In-Reply-To: <1512210741-475-1-git-send-email-linux@wolf-entwicklungen.de>
On Sat, Dec 02, 2017 at 12:32:20PM +0200, Marcus Wolf wrote:
> Defines used in cases contain already shifted bits, so currentValue must not be shifted.
Please properly wrap your changelog text.
And you need a blank line before your signed-off-by line.
> signed_of_by: Marcus Wolf <linux@wolf-entwicklungen.de>
"Signed-off-by:"
Did you run scripts/checkpatch.pl on your patch?
You sent 4 patches just now, which order should I apply them in? I have
no idea, so please fix them up and resend them as a numbered patch
series so that I have a chance to get it right.
thanks,
greg k-h
next prev parent reply other threads:[~2017-12-02 15:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-02 10:32 [PATCH] staging: pi433: Bugfix for shift operation in rf69_get_modulation() Marcus Wolf
2017-12-02 14:58 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-12-02 10:51 Marcus Wolf
2017-12-02 14:59 ` Greg KH
2017-12-02 9:58 Marcus Wolf
2017-12-02 10:06 ` Greg KH
2017-12-02 10:10 ` Marcus Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171202145843.GB1242@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@wolf-entwicklungen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox