public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Marcus Wolf <marcus.wolf@smarthome-wolf.de>
Cc: Marcus Wolf <linux@wolf-entwicklungen.de>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	dan.carpenter@oracle.com
Subject: Re: [PATCH] staging: pi433: Removed some obsolete or duplicated defines; moved two defines to better locations
Date: Sat, 2 Dec 2017 16:09:28 +0000	[thread overview]
Message-ID: <20171202160928.GA7067@kroah.com> (raw)
In-Reply-To: <30f27e3f-bd83-f44b-f0b1-f3c97fa2373c@smarthome-wolf.de>


A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Sat, Dec 02, 2017 at 06:00:28PM +0200, Marcus Wolf wrote:
> Hi Greg,
> 
> for me the action was "clean up the defines in rf69.c". So for me it was
> fine, that two defines were moved and several other deleted at the same.
> 
> Is it ok for you, or should I split the patch belated?

Please split it up, and make a patch series.  Don't dribble patches out
over many hours as that just ensures that I will apply them in the wrong
order :(

Take the time, make a patch series, test that they pass the scripts that
we have, and then send them all out at once.

thanks,

greg k-h

  reply	other threads:[~2017-12-02 16:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-02 15:14 [PATCH] staging: pi433: Removed some obsolete or duplicated defines; moved two defines to better locations Marcus Wolf
2017-12-02 15:55 ` Greg KH
2017-12-02 16:00   ` Marcus Wolf
2017-12-02 16:09     ` Greg KH [this message]
2017-12-02 16:35       ` Marcus Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171202160928.GA7067@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@wolf-entwicklungen.de \
    --cc=marcus.wolf@smarthome-wolf.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox