From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752276AbdLCNuz (ORCPT ); Sun, 3 Dec 2017 08:50:55 -0500 Received: from mail-pl0-f65.google.com ([209.85.160.65]:42857 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751619AbdLCNuv (ORCPT ); Sun, 3 Dec 2017 08:50:51 -0500 X-Google-Smtp-Source: AGs4zMZqEMRKy54DSMXnhhivRtymnTRNeXinYdlcFGgcc4e7Pv7ZtmacAg8mx7WC/U4E2rB79hw2qg== From: Song Seok Ho <0xdevssh@gmail.com> To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim , Song Seok Ho <0xdevssh@gmail.com> Subject: [PATCH] perf tools: set GUI mode after returning from perf_session__new() Date: Sun, 3 Dec 2017 22:50:38 +0900 Message-Id: <20171203135038.16977-1-0xdevssh@gmail.com> X-Mailer: git-send-email 2.15.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If perf_session__new() returns NULL with use_browser set to 2 via --gtk option previously, perf dies quietly without printing any errors. The reason behind this is that GTK is not yet initialized when the caller inside perf_session__new() is trying to print error message to the screen. Reorder code to print the messages to stdio when GTK is not yet ready. Signed-off-by: Song Seok Ho <0xdevssh@gmail.com> --- tools/perf/builtin-report.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index 1394cd8d96f7..0cd80b8c432e 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c @@ -918,13 +918,6 @@ int cmd_report(int argc, const char **argv) return -EINVAL; } - if (report.use_stdio) - use_browser = 0; - else if (report.use_tui) - use_browser = 1; - else if (report.use_gtk) - use_browser = 2; - if (report.inverted_callchain) callchain_param.order = ORDER_CALLER; if (symbol_conf.cumulate_callchain && !callchain_param.order_set) @@ -949,6 +942,13 @@ int cmd_report(int argc, const char **argv) if (session == NULL) return -1; + if (report.use_stdio) + use_browser = 0; + else if (report.use_tui) + use_browser = 1; + else if (report.use_gtk) + use_browser = 2; + if (report.queue_size) { ordered_events__set_alloc_size(&session->ordered_events, report.queue_size); -- 2.15.1