From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753641AbdLDMGC (ORCPT ); Mon, 4 Dec 2017 07:06:02 -0500 Received: from smtprelay0119.hostedemail.com ([216.40.44.119]:38840 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752132AbdLDMF5 (ORCPT ); Mon, 4 Dec 2017 07:05:57 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3872:5007:6261:7875:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12114:12296:12438:12555:12663:12740:12760:12895:13069:13311:13357:13439:14096:14097:14181:14659:14721:21080:21451:21627:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: pipe02_169566607f228 X-Filterd-Recvd-Size: 1978 Date: Mon, 4 Dec 2017 07:05:51 -0500 From: Steven Rostedt To: Matthias Kaehlcke Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Douglas Anderson Subject: Re: [PATCH] ring-buffer: Remove unused function __rb_data_page_index() Message-ID: <20171204070551.3b891648@vmware.local.home> In-Reply-To: <20170518001415.5223-1-mka@chromium.org> References: <20170518001415.5223-1-mka@chromium.org> X-Mailer: Claws Mail 3.15.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 May 2017 17:14:15 -0700 Matthias Kaehlcke wrote: > This fixes the following warning when building with clang: > > kernel/trace/ring_buffer.c:1842:1: error: unused function > '__rb_data_page_index' [-Werror,-Wunused-function] Ug, I this patch somehow fell through. I'm applying it now. -- Steve > > Signed-off-by: Matthias Kaehlcke > --- > kernel/trace/ring_buffer.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c > index 4ae268e687fe..a6b87582c4ff 100644 > --- a/kernel/trace/ring_buffer.c > +++ b/kernel/trace/ring_buffer.c > @@ -1800,12 +1800,6 @@ void ring_buffer_change_overwrite(struct ring_buffer *buffer, int val) > } > EXPORT_SYMBOL_GPL(ring_buffer_change_overwrite); > > -static __always_inline void * > -__rb_data_page_index(struct buffer_data_page *bpage, unsigned index) > -{ > - return bpage->data + index; > -} > - > static __always_inline void *__rb_page_index(struct buffer_page *bpage, unsigned index) > { > return bpage->page->data + index;