From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753883AbdLDJKz (ORCPT <rfc822;w@1wt.eu>);
        Mon, 4 Dec 2017 04:10:55 -0500
Received: from sci-ig2.spreadtrum.com ([222.66.158.135]:64911 "EHLO
        SHSQR01.spreadtrum.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org
        with ESMTP id S1752860AbdLDJKv (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 4 Dec 2017 04:10:51 -0500
Date: Mon, 4 Dec 2017 17:03:14 +0800
From: Erick Chen <erick.chen@spreadtrum.com>
To: Mark Brown <broonie@kernel.org>
CC: <robh+dt@kernel.org>, <mark.rutland@arm.com>, <lgirdwood@gmail.com>,
        <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <baolin.wang@linaro.org>, <baolin.wang@spreadtrum.com>
Subject: Re: [PATCH 2/2] regulator: sc2731: Add regulator driver to support
 Spreadtrum SC2731 PMIC
Message-ID: <20171204090313.GA2242@spreadtrum.com>
References: <f6d8ff765f4864e5b6ace1f022202d8793a7becf.1512118703.git.erick.chen@spreadtrum.com>
 <75a6a48f603a25d744ef46287e036975b0203608.1512118703.git.erick.chen@spreadtrum.com>
 <201712020333.vB23X0mT082692@TPSPAM01.spreadtrum.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <201712020333.vB23X0mT082692@TPSPAM01.spreadtrum.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-MAIL: SHSQR01.spreadtrum.com vB498F99072677
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Mark,

On Fri, Dec 01, 2017 at 01:01:37PM +0000, Mark Brown wrote:
> On Fri, Dec 01, 2017 at 04:58:16PM +0800, Erick Chen wrote:
> 
> > +static const struct of_device_id sc2731_regulator_of_match[] = {
> > +	{.compatible = "sprd,sc2731-regulator",},
> > +	{}
> > +};
> > +MODULE_DEVICE_TABLE(of, sc2731_regulator_of_match);
> 
> This looks like a subdriver for one specific device that can't be reused
> with anything else as it's specific to an individual device so I'd not
> expect it to appear as a separate thing in DT - the way Linux splits
> things up might not map well onto other OSs and may even change in
> future versions of Linux (look at all the audio drivers with clock
> controllers in them for example).  I'd expect the MFD to just register
> the subdevice without needing it to appear in the DT.
>

Make sense, i will remove the of_device_id table in next version.
 
> > +subsys_initcall(sc2731_regulator_init);
> > +module_exit(sc2731_regulator_exit);
> 
> Why not module_platform_driver()?  Deferred probe should sort out probe
> order.

On some Spreadtrum old platforms, we need to power on the CPU cores ASAP.
But now this issue had been fixed after some investigation, so we can change
subsys_initcall() to module_init() level as you suggested.

Very appreciated for your helpful comments.