From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753684AbdLDJUl (ORCPT ); Mon, 4 Dec 2017 04:20:41 -0500 Received: from sci-ig2.spreadtrum.com ([222.66.158.135]:21235 "EHLO SHSQR01.spreadtrum.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752930AbdLDJUi (ORCPT ); Mon, 4 Dec 2017 04:20:38 -0500 Date: Mon, 4 Dec 2017 17:11:24 +0800 From: Erick Chen To: Philippe Ombredanne CC: Mark , Rob Herring , Mark Rutland , , LKML , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , , Subject: Re: [PATCH 2/2] regulator: sc2731: Add regulator driver to support Spreadtrum SC2731 PMIC Message-ID: <20171204091118.GB2242@spreadtrum.com> References: <75a6a48f603a25d744ef46287e036975b0203608.1512118703.git.erick.chen@spreadtrum.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-MAIL: SHSQR01.spreadtrum.com vB49GNcK091466 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Philippe, On Fri, Dec 01, 2017 at 10:13:27AM +0100, Philippe Ombredanne wrote: > Erik, > > On Fri, Dec 1, 2017 at 9:58 AM, Erick Chen wrote: > > Add regulator driver for Spreadtrum SC2731 device. > > It has 17 general purpose LDOs, BUCKs generator and > > digital output to control regulators. > > > > Signed-off-by: Erick Chen > > Reviewed-by: Baolin Wang > > --- > > drivers/regulator/Kconfig | 7 + > > drivers/regulator/Makefile | 1 + > > drivers/regulator/sc2731-regulator.c | 276 ++++++++++++++++++++++++++++++++++ > > 3 files changed, 284 insertions(+) > > create mode 100644 drivers/regulator/sc2731-regulator.c > > > > diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig > > index 96cd55f..b27417c 100644 > > --- a/drivers/regulator/Kconfig > > +++ b/drivers/regulator/Kconfig > > @@ -744,6 +744,13 @@ config REGULATOR_S5M8767 > > via I2C bus. S5M8767A have 9 Bucks and 28 LDOs output and > > supports DVS mode with 8bits of output voltage control. > > > > +config REGULATOR_SC2731 > > + tristate "Spreadtrum SC2731 power regulator driver" > > + depends on MFD_SC27XX_PMIC || COMPILE_TEST > > + help > > + This driver provides support for the voltage regulators on the > > + SC2731 PMIC. > > + > > config REGULATOR_SKY81452 > > tristate "Skyworks Solutions SKY81452 voltage regulator" > > depends on MFD_SKY81452 > > diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile > > index 80ffc57..19fea09 100644 > > --- a/drivers/regulator/Makefile > > +++ b/drivers/regulator/Makefile > > @@ -95,6 +95,7 @@ obj-$(CONFIG_REGULATOR_RT5033) += rt5033-regulator.o > > obj-$(CONFIG_REGULATOR_S2MPA01) += s2mpa01.o > > obj-$(CONFIG_REGULATOR_S2MPS11) += s2mps11.o > > obj-$(CONFIG_REGULATOR_S5M8767) += s5m8767.o > > +obj-$(CONFIG_REGULATOR_SC2731) += sc2731-regulator.o > > obj-$(CONFIG_REGULATOR_SKY81452) += sky81452-regulator.o > > obj-$(CONFIG_REGULATOR_STM32_VREFBUF) += stm32-vrefbuf.o > > obj-$(CONFIG_REGULATOR_STW481X_VMMC) += stw481x-vmmc.o > > diff --git a/drivers/regulator/sc2731-regulator.c b/drivers/regulator/sc2731-regulator.c > > new file mode 100644 > > index 0000000..e56448a > > --- /dev/null > > +++ b/drivers/regulator/sc2731-regulator.c > > @@ -0,0 +1,276 @@ > > +/* > > + * Copyright (C) 2017 Spreadtrum Communications Inc. > > + * > > + * SPDX-License-Identifier: GPL-2.0 > > + */ > > I think that per Linus, and Thomas doc patches for SPDX ids this > should be instead either: > > > +// SPDX-License-Identifier: GPL-2.0 > > + // Copyright (c) 2017 Spreadtrum Communications Inc. > > or at least this with the id on the first and the // comment style > Thanks for pointing out this, and I will modify them in next version. > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (C) 2017 Spreadtrum Communications Inc. > > + * > > + */