From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: SeokHo Song <0xdevssh@gmail.com>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH] perf tools: set GUI mode after returning from perf_session__new()
Date: Mon, 4 Dec 2017 13:28:13 -0300 [thread overview]
Message-ID: <20171204162813.GI13698@kernel.org> (raw)
In-Reply-To: <CABdrxx-65yZ5WURu57kUBozsL0Yu2dqNgjiirT3CW7SYQqvFpg@mail.gmail.com>
Em Tue, Dec 05, 2017 at 01:11:49AM +0900, SeokHo Song escreveu:
> Hi Arnaldo,
>
> 2017-12-05 0:45 GMT+09:00 Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>:
> > Em Tue, Dec 05, 2017 at 12:05:18AM +0900, Namhyung Kim escreveu:
> >> Hi SeokHo,
> >>
> >> On Sun, Dec 3, 2017 at 10:50 PM, Song Seok Ho <0xdevssh@gmail.com> wrote:
> >> > If perf_session__new() returns NULL with use_browser set to 2 via --gtk option
> >> > previously, perf dies quietly without printing any errors.
> >> >
> >> > The reason behind this is that GTK is not yet initialized when the caller
> >> > inside perf_session__new() is trying to print error message to the screen.
> >> >
> >> > Reorder code to print the messages to stdio when GTK is not yet ready.
> >>
> >> I'm ok with this change, but it needs to consider other error messages too.
> >> There are more pr_err() calls between perf_session__new() and
> >> setup_browser(), so I think they have same problem.
> >
> > So I think I can apply this one, with Namhyung's acked-by and then Song
> > can continue with followup patches?
> >
> > - Arnaldo
> >
>
> I've sent a follow-up patch with a new title "[PATCH v2] perf tools:
> set browser mode
> right before setup_browser()" with Namhyung's Acked-by added.
>
> Addressing Namhyung's comment, I've moved the use_browser variable assignment
> code below when setup_browser() is called.
>
> Please let me know if it deserves to be in a different place.
Ok, I've replaced the copy I had with this v2 one.
- Arnaldo
prev parent reply other threads:[~2017-12-04 16:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-03 13:50 [PATCH] perf tools: set GUI mode after returning from perf_session__new() Song Seok Ho
2017-12-04 15:05 ` Namhyung Kim
2017-12-04 15:45 ` Arnaldo Carvalho de Melo
2017-12-04 16:11 ` SeokHo Song
2017-12-04 16:28 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204162813.GI13698@kernel.org \
--to=acme@kernel.org \
--cc=0xdevssh@gmail.com \
--cc=arnaldo.melo@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox