From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753415AbdLDQ2U (ORCPT ); Mon, 4 Dec 2017 11:28:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:41412 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752967AbdLDQ2Q (ORCPT ); Mon, 4 Dec 2017 11:28:16 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BCC62148C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Mon, 4 Dec 2017 13:28:13 -0300 From: Arnaldo Carvalho de Melo To: SeokHo Song <0xdevssh@gmail.com> Cc: Arnaldo Carvalho de Melo , Namhyung Kim , linux-kernel@vger.kernel.org, Jiri Olsa Subject: Re: [PATCH] perf tools: set GUI mode after returning from perf_session__new() Message-ID: <20171204162813.GI13698@kernel.org> References: <20171203135038.16977-1-0xdevssh@gmail.com> <20171204154541.GD13698@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Dec 05, 2017 at 01:11:49AM +0900, SeokHo Song escreveu: > Hi Arnaldo, > > 2017-12-05 0:45 GMT+09:00 Arnaldo Carvalho de Melo : > > Em Tue, Dec 05, 2017 at 12:05:18AM +0900, Namhyung Kim escreveu: > >> Hi SeokHo, > >> > >> On Sun, Dec 3, 2017 at 10:50 PM, Song Seok Ho <0xdevssh@gmail.com> wrote: > >> > If perf_session__new() returns NULL with use_browser set to 2 via --gtk option > >> > previously, perf dies quietly without printing any errors. > >> > > >> > The reason behind this is that GTK is not yet initialized when the caller > >> > inside perf_session__new() is trying to print error message to the screen. > >> > > >> > Reorder code to print the messages to stdio when GTK is not yet ready. > >> > >> I'm ok with this change, but it needs to consider other error messages too. > >> There are more pr_err() calls between perf_session__new() and > >> setup_browser(), so I think they have same problem. > > > > So I think I can apply this one, with Namhyung's acked-by and then Song > > can continue with followup patches? > > > > - Arnaldo > > > > I've sent a follow-up patch with a new title "[PATCH v2] perf tools: > set browser mode > right before setup_browser()" with Namhyung's Acked-by added. > > Addressing Namhyung's comment, I've moved the use_browser variable assignment > code below when setup_browser() is called. > > Please let me know if it deserves to be in a different place. Ok, I've replaced the copy I had with this v2 one. - Arnaldo