* [PATCH] dma: MIC X100: Use PTR_ERR_OR_ZERO()
@ 2017-11-27 23:07 Vasyl Gomonovych
2017-12-04 17:11 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Vasyl Gomonovych @ 2017-11-27 23:07 UTC (permalink / raw)
To: sudeep.dutt, ashutosh.dixit, dan.j.williams, vinod.koul,
dmaengine
Cc: linux-kernel, gomonovych
Fix ptr_ret.cocci warnings:
drivers/dma/mic_x100_dma.c:483:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
drivers/dma/mic_x100_dma.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/dma/mic_x100_dma.c b/drivers/dma/mic_x100_dma.c
index 5ba5714d0b7c..94d7bd7d2880 100644
--- a/drivers/dma/mic_x100_dma.c
+++ b/drivers/dma/mic_x100_dma.c
@@ -480,9 +480,7 @@ static int mic_dma_setup_irq(struct mic_dma_chan *ch)
to_mbus_hw_ops(ch)->request_threaded_irq(to_mbus_device(ch),
mic_dma_intr_handler, mic_dma_thread_fn,
"mic dma_channel", ch, ch->ch_num);
- if (IS_ERR(ch->cookie))
- return PTR_ERR(ch->cookie);
- return 0;
+ return PTR_ERR_OR_ZERO(ch->cookie);
}
static inline void mic_dma_free_irq(struct mic_dma_chan *ch)
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dma: MIC X100: Use PTR_ERR_OR_ZERO()
2017-11-27 23:07 [PATCH] dma: MIC X100: Use PTR_ERR_OR_ZERO() Vasyl Gomonovych
@ 2017-12-04 17:11 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2017-12-04 17:11 UTC (permalink / raw)
To: Vasyl Gomonovych
Cc: sudeep.dutt, ashutosh.dixit, dan.j.williams, dmaengine,
linux-kernel
On Tue, Nov 28, 2017 at 12:07:08AM +0100, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/dma/mic_x100_dma.c:483:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
Applied after fixing subystem name and driver tag
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-04 17:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-27 23:07 [PATCH] dma: MIC X100: Use PTR_ERR_OR_ZERO() Vasyl Gomonovych
2017-12-04 17:11 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox