From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752617AbdLDS2o (ORCPT ); Mon, 4 Dec 2017 13:28:44 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:53484 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751380AbdLDS2k (ORCPT ); Mon, 4 Dec 2017 13:28:40 -0500 Date: Mon, 4 Dec 2017 10:28:35 -0800 From: "Paul E. McKenney" To: Lai Jiangshan Cc: LKML , Ingo Molnar , dipankar@in.ibm.com, akpm@linux-foundation.org, Mathieu Desnoyers , Josh Triplett , Thomas Gleixner , Peter Zijlstra , Steven Rostedt , David Howells , Eric Dumazet , =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , oleg@redhat.com, Tejun Heo Subject: Re: [PATCH tip/core/rcu 05/10] workqueue: Eliminate cond_resched_rcu_qs() in favor of cond_resched() Reply-To: paulmck@linux.vnet.ibm.com References: <20171201192122.GA19301@linux.vnet.ibm.com> <1512156104-20104-5-git-send-email-paulmck@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17120418-0008-0000-0000-000002AA9E63 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008152; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000243; SDB=6.00955403; UDB=6.00482864; IPR=6.00735440; BA=6.00005727; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00018343; XFM=3.00000015; UTC=2017-12-04 18:28:37 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17120418-0009-0000-0000-0000377FA9D2 Message-Id: <20171204182835.GZ7829@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-04_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712040261 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 02, 2017 at 09:06:29AM +0800, Lai Jiangshan wrote: > On Sat, Dec 2, 2017 at 3:21 AM, Paul E. McKenney > wrote: > > Now that cond_resched() also provides RCU quiescent states when > > needed, it can be used in place of cond_resched_rcu_qs(). This > > commit therefore makes this change. > > > > Signed-off-by: Paul E. McKenney > > Cc: Tejun Heo > > Cc: Lai Jiangshan > > Reviewed-by: Lai Jiangshan Applied, thank you for the review! Thanx, Paul > > --- > > kernel/workqueue.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/kernel/workqueue.c b/kernel/workqueue.c > > index 8fdb710bfdd7..aee7eaab05cb 100644 > > --- a/kernel/workqueue.c > > +++ b/kernel/workqueue.c > > @@ -2135,7 +2135,7 @@ __acquires(&pool->lock) > > * stop_machine. At the same time, report a quiescent RCU state so > > * the same condition doesn't freeze RCU. > > */ > > - cond_resched_rcu_qs(); > > + cond_resched(); > > > > spin_lock_irq(&pool->lock); > > > > -- > > 2.5.2 > > >