From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752151AbdLDUSc (ORCPT ); Mon, 4 Dec 2017 15:18:32 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:42377 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751711AbdLDUS2 (ORCPT ); Mon, 4 Dec 2017 15:18:28 -0500 X-Google-Smtp-Source: AGs4zMbZgp5dCwlAihi4U7kOtubDKk7agmFOgVF3XEt02JZh/4+wwYjyxtI3flK2vlNtXI5pQmUvcQ== Date: Mon, 4 Dec 2017 12:18:21 -0800 From: Bjorn Andersson To: Rob Herring Cc: Andy Gross , David Brown , Mark Rutland , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Arun Kumar Neelakantam Subject: Re: [PATCH v2] soc: qcom: smp2p: Access APCS as mailbox client Message-ID: <20171204201821.GC28761@minitux> References: <20171130000040.23681-1-bjorn.andersson@linaro.org> <20171201222545.hkp73cuou6aildky@rob-hp-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171201222545.hkp73cuou6aildky@rob-hp-laptop> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 01 Dec 14:25 PST 2017, Rob Herring wrote: > On Wed, Nov 29, 2017 at 04:00:40PM -0800, Bjorn Andersson wrote: > > Attempt to acquire the APCS IPC through the mailbox framework and fall > > back to the old syscon based approach, to allow us to move away from > > using the syscon. > > > > Signed-off-by: Bjorn Andersson > > --- > > > > Changes since v1: > > - Added dt binding update > > - Specifies knows_txdone on the mailbox client > > > > .../devicetree/bindings/soc/qcom/qcom,smp2p.txt | 8 ++++- > > drivers/soc/qcom/Kconfig | 1 + > > drivers/soc/qcom/smp2p.c | 39 ++++++++++++++++++---- > > 3 files changed, 41 insertions(+), 7 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smp2p.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,smp2p.txt > > index af9ca37221ce..a35af2dafdad 100644 > > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,smp2p.txt > > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smp2p.txt > > @@ -17,9 +17,15 @@ processor ID) and a string identifier. > > Value type: > > Definition: one entry specifying the smp2p notification interrupt > > > > -- qcom,ipc: > > +- mboxes: > > Usage: required > > Value type: > > + Definition: reference to the associated doorbell in APCS, as described > > + in mailbox/mailbox.txt > > + > > +- qcom,ipc: > > + Usage: required, unless mboxes is specified > > Is this deprecated as mboxes is required, so it's never present? > Right, this required property "mboxes" replaces the previously required property "qcom,ipc". This comes from migrating the description of APCS as a syscon to a mailbox/doorbell. Regards, Bjorn > > + Value type: > > Definition: three entries specifying the outgoing ipc bit used for > > signaling the remote end of the smp2p edge: > > - phandle to a syscon node representing the apcs registers