* [PATCH] workqueue/hotplug: remove the workaround in rebind_workers()
@ 2017-12-01 14:23 Lai Jiangshan
2017-12-04 21:11 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Lai Jiangshan @ 2017-12-01 14:23 UTC (permalink / raw)
To: linux-kernel; +Cc: Thomas Gleixner, Lai Jiangshan, Tejun Heo
Sine the cpu/hotplug refactor is done, the hotplug
callbacks are called properly. So the workaround is
useless.
Signed-off-by: Lai Jiangshan <jiangshanlai@gmail.com>
---
kernel/workqueue.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 5c99beb8577d..528321bc45eb 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -4588,16 +4588,6 @@ static void rebind_workers(struct worker_pool *pool)
spin_lock_irq(&pool->lock);
- /*
- * XXX: CPU hotplug notifiers are weird and can call DOWN_FAILED
- * w/o preceding DOWN_PREPARE. Work around it. CPU hotplug is
- * being reworked and this can go away in time.
- */
- if (!(pool->flags & POOL_DISASSOCIATED)) {
- spin_unlock_irq(&pool->lock);
- return;
- }
-
pool->flags &= ~POOL_DISASSOCIATED;
for_each_pool_worker(worker, pool) {
--
2.13.6 (Apple Git-96)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] workqueue/hotplug: remove the workaround in rebind_workers()
2017-12-01 14:23 [PATCH] workqueue/hotplug: remove the workaround in rebind_workers() Lai Jiangshan
@ 2017-12-04 21:11 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2017-12-04 21:11 UTC (permalink / raw)
To: Lai Jiangshan; +Cc: linux-kernel, Thomas Gleixner
On Fri, Dec 01, 2017 at 10:23:07PM +0800, Lai Jiangshan wrote:
> Sine the cpu/hotplug refactor is done, the hotplug
> callbacks are called properly. So the workaround is
> useless.
>
> Signed-off-by: Lai Jiangshan <jiangshanlai@gmail.com>
Applied to wq/for-4.16 w/ desc updates.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-04 21:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-01 14:23 [PATCH] workqueue/hotplug: remove the workaround in rebind_workers() Lai Jiangshan
2017-12-04 21:11 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox