From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752879AbdLDVop (ORCPT ); Mon, 4 Dec 2017 16:44:45 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:39457 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752310AbdLDVoo (ORCPT ); Mon, 4 Dec 2017 16:44:44 -0500 X-ME-Sender: Date: Tue, 5 Dec 2017 08:44:40 +1100 From: "Tobin C. Harding" To: Kees Cook Cc: Jonathan Corbet , Laura Abbott , Jessica Yu , linux-doc@vger.kernel.org, LKML Subject: Re: [PATCH] doc: update 'unique identifiers' Message-ID: <20171204214440.GH21565@eros> References: <1512422560-31290-1-git-send-email-me@tobin.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: Mutt 1.5.24 (2015-08-30) User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 04, 2017 at 01:28:45PM -0800, Kees Cook wrote: > On Mon, Dec 4, 2017 at 1:22 PM, Tobin C. Harding wrote: > > Advice about what to use as a unique identifier is no longer valid since > > patch series was merged to hash pointers printed with %p. We can use > > this as a unique identifier now. > > > > Signed-off-by: Tobin C. Harding > > I don't agree: %p should still not be encouraged. Exposing an > identifier to userspace needs careful consideration, and atomics, > idrs, etc, continue to be a good recommendation here, as far as I'm > concerned. Ok no worries, so these docs are valid and current as is? I have no agenda with this patch, just attempting to keep the docs in line with the code :) thanks, Tobin.