From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751941AbdLDXjm (ORCPT <rfc822;w@1wt.eu>);
        Mon, 4 Dec 2017 18:39:42 -0500
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:50411 "EHLO
        out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751156AbdLDXjj (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 4 Dec 2017 18:39:39 -0500
X-ME-Sender: <xms:u9wlWom0UgMdbsfMPcrsuK1Ra6uMkdDJZh6dOBqmmqRTPiwpp7PvnQ>
Date: Tue, 5 Dec 2017 10:39:36 +1100
From: "Tobin C. Harding" <me@tobin.cc>
To: Kees Cook <keescook@chromium.org>
Cc: Jonathan Corbet <corbet@lwn.net>, Laura Abbott <labbott@redhat.com>,
        Jessica Yu <jeyu@redhat.com>, linux-doc@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] doc: update 'unique identifiers'
Message-ID: <20171204233936.GK21565@eros>
References: <1512422560-31290-1-git-send-email-me@tobin.cc>
 <CAGXu5jKKojS4SjHwwxKKeU=5HCBuv_iFROHC+r3jb9D4BY4U0w@mail.gmail.com>
 <20171204214440.GH21565@eros>
 <CAGXu5jKkVuoOa+Uxs0Mho+QUUbHEe4kWBEQ3b=5hDSvfY0BEwA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAGXu5jKkVuoOa+Uxs0Mho+QUUbHEe4kWBEQ3b=5hDSvfY0BEwA@mail.gmail.com>
X-Mailer: Mutt 1.5.24 (2015-08-30)
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Dec 04, 2017 at 01:51:42PM -0800, Kees Cook wrote:
> On Mon, Dec 4, 2017 at 1:44 PM, Tobin C. Harding <me@tobin.cc> wrote:
> > On Mon, Dec 04, 2017 at 01:28:45PM -0800, Kees Cook wrote:
> >> On Mon, Dec 4, 2017 at 1:22 PM, Tobin C. Harding <me@tobin.cc> wrote:
> >> > Advice about what to use as a unique identifier is no longer valid since
> >> > patch series was merged to hash pointers printed with %p. We can use
> >> > this as a unique identifier now.
> >> >
> >> > Signed-off-by: Tobin C. Harding <me@tobin.cc>
> >>
> >> I don't agree: %p should still not be encouraged. Exposing an
> >> identifier to userspace needs careful consideration, and atomics,
> >> idrs, etc, continue to be a good recommendation here, as far as I'm
> >> concerned.
> >
> > Ok no worries, so these docs are valid and current as is? I have no
> > agenda with this patch, just attempting to keep the docs in line with
> > the code :)
> 
> I think a section could be added/updated discussing leaks and %p (in
> that it is hashing now), that would be quite welcome!
> 
> I do, probably need to go through this document and update a few things.

How about I do whatever generates the least amount of work for you. Is
it easier if I add the %p stuff for you to review or is it easier to
just leave it for you to do in your own time?

thanks,
Tobin.