From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752370AbdLECqh (ORCPT ); Mon, 4 Dec 2017 21:46:37 -0500 Received: from mail-yb0-f169.google.com ([209.85.213.169]:37667 "EHLO mail-yb0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751852AbdLECqe (ORCPT ); Mon, 4 Dec 2017 21:46:34 -0500 X-Google-Smtp-Source: AGs4zMYb/o9JLku2KVV9VIy7AyRXjtFl1QZHnKmJt+0whIkvNNQagh9bz7Sc1IRBCHWyTALxEnLKJQ== Date: Mon, 4 Dec 2017 18:46:28 -0800 From: Eduardo Valentin To: Nicolin Chen Cc: rui.zhang@intel.com, srikars@nvidia.com, thierry.reding@gmail.com, jonathanh@nvidia.com, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] thermal: tegra: allow sensor registeration to fail Message-ID: <20171205024625.GC4949@localhost.localdomain> References: <1509148453-11388-1-git-send-email-nicoleotsuka@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509148453-11388-1-git-send-email-nicoleotsuka@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vB52kfcg028783 Hello, On Fri, Oct 27, 2017 at 04:54:13PM -0700, Nicolin Chen wrote: > Not all sensors may be used on a platform. So there could be > some missing thermal zones in the Device Tree. However, the > the driver now errors out whenever a sensor fails to register > the thermal zone. > > Since the driver could live with other sensors, this change > allows other sensors to continue the registerations even if > one sensor fails to register. What would be the use case you want to have your chip running with failed to probe thermal zones ? If they are failing to probe shouldnt you fix the DT nodes? a system with correct DT, failed to probe zones is a real bug. Either in the DT or in the code. > > Signed-off-by: Nicolin Chen > --- >