From: "Liu, Changcheng" <changcheng.liu@intel.com>
To: paulmck@linux.vnet.ibm.com, mingo@kernel.org, tglx@linutronix.de,
bigeasy@linutronix.de
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
changcheng.liu@intel.com
Subject: [PATCH] kernel/stop_machine: fix (de)reference function pointer
Date: Tue, 5 Dec 2017 13:02:46 +0800 [thread overview]
Message-ID: <20171205050246.GA81448@sofia> (raw)
It's better to avoid ambiguity when (de)referencing function
pointer.
Signed-off-by: Liu Changcheng <changcheng.liu@intel.com>
diff --git a/kernel/stop_machine.c b/kernel/stop_machine.c
index b759126..121d6aa 100644
--- a/kernel/stop_machine.c
+++ b/kernel/stop_machine.c
@@ -577,7 +577,7 @@ int stop_machine_cpuslocked(cpu_stop_fn_t fn, void *data,
local_irq_save(flags);
hard_irq_disable();
- ret = (*fn)(data);
+ ret = fn(data);
local_irq_restore(flags);
return ret;
--
2.7.4
reply other threads:[~2017-12-05 5:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205050246.GA81448@sofia \
--to=changcheng.liu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox