From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752298AbdLEGCA (ORCPT ); Tue, 5 Dec 2017 01:02:00 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36995 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752179AbdLEGB5 (ORCPT ); Tue, 5 Dec 2017 01:01:57 -0500 X-Google-Smtp-Source: AGs4zMbrcoxKr0OAiQ+PJ22icjFB38loYOlxbvXTBz3frM4/F9vCKZUzH7w9cesddWvHiVnnUEpW0w== Date: Mon, 4 Dec 2017 22:01:50 -0800 From: Bjorn Andersson To: Georgi Djakov Cc: sboyd@codeaurora.org, jassisinghbrar@gmail.com, robh@kernel.org, mturquette@baylibre.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v10 2/6] mailbox: qcom: Create APCS child device for clock controller Message-ID: <20171205060150.GJ28761@minitux> References: <20171201170224.25053-1-georgi.djakov@linaro.org> <20171201170224.25053-3-georgi.djakov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171201170224.25053-3-georgi.djakov@linaro.org> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 01 Dec 09:02 PST 2017, Georgi Djakov wrote: > There is a clock controller functionality provided by the APCS hardware > block of msm8916 devices. The device-tree would represent an APCS node > with both mailbox and clock provider properties. > Create a platform child device for the clock controller functionality so > the driver can probe and use APCS as parent. > > Signed-off-by: Georgi Djakov Acked-by: Bjorn Andersson Regards, Bjorn > --- > drivers/mailbox/qcom-apcs-ipc-mailbox.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c > index ab344bc6fa63..57bde0dfd12f 100644 > --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c > +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c > @@ -29,6 +29,7 @@ struct qcom_apcs_ipc { > > struct regmap *regmap; > unsigned long offset; > + struct platform_device *clk; > }; > > static const struct regmap_config apcs_regmap_config = { > @@ -96,6 +97,14 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev) > return ret; > } > > + if (of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global")) { > + apcs->clk = platform_device_register_data(&pdev->dev, > + "qcom-apcs-msm8916-clk", > + -1, NULL, 0); > + if (IS_ERR(apcs->clk)) > + dev_err(&pdev->dev, "failed to register APCS clk\n"); > + } > + > platform_set_drvdata(pdev, apcs); > > return 0; > @@ -104,8 +113,10 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev) > static int qcom_apcs_ipc_remove(struct platform_device *pdev) > { > struct qcom_apcs_ipc *apcs = platform_get_drvdata(pdev); > + struct platform_device *clk = apcs->clk; > > mbox_controller_unregister(&apcs->mbox); > + platform_device_unregister(clk); > > return 0; > }