Re: [PATCH] [linux][master][v1] misc: Add Xilinx ZYNQMP VCU logicoreIP init driver

Greg Kroah-Hartman
2017-12-07T10:47:52Z

On Thu, Dec 07, 2017 at 10:30:45AM +0000, Dhaval Rajeshbhai Shah wrote:
>
>
> > -----Original Message-----
> > From: Philippe Ombredanne [mailto:pombredanne@nexb.com]
> > Sent: Thursday, December 07, 2017 2:07 AM
> > To: Dhaval Rajeshbhai Shah <DSHAH@xilinx.com>
> > Cc: Arnd Bergmann <arnd@arndb.de>; Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org>; LKML <linux-kernel@vger.kernel.org>;
> > michal.simek@xilinx.com; Hyun Kwon <hyunk@xilinx.com>; Dhaval
> > Rajeshbhai Shah <DSHAH@xilinx.com>
> > Subject: Re: [PATCH] [linux][master][v1] misc: Add Xilinx ZYNQMP VCU
> > logicoreIP init driver
> >
> > Daval,
> >
> > On Tue, Dec 5, 2017 at 12:43 PM, Dhaval Shah <dhaval.shah@xilinx.com>
> > wrote:
> > > Xilinx ZYNQMP VCU Init driver is based on the new LogiCoreIP design
> > > created. This driver will provide the api which can be used by the
> > > encoder and decoder driver to get the configured value.
> > >
> > > Signed-off-by: Dhaval Shah <dshah@xilinx.com>
> > []
> > > diff --git a/drivers/misc/xlnx_vcu.c b/drivers/misc/xlnx_vcu.c new
> > > file mode 100644 index 0000000..373f7f9
> > > --- /dev/null
> > > +++ b/drivers/misc/xlnx_vcu.c
> > > @@ -0,0 +1,664 @@
> > > +/*
> > > + * Xilinx VCU Init
> > > + *
> > > + * Copyright (C) 2016 - 2017 Xilinx, Inc.
> > > + *
> > > + * Contacts Dhaval Shah <dshah@xilinx.com>
> > > + *
> > > + * SPDX-License-Identifier: GPL-2.0
> > > + */
> >
> > The SPDX id should be on the first line with a C++ // style comment instead as
> > requested by Linus.
> I will take care of this Changes as also suggested by the Greg k-h as well once get the ACK for the remaining reply from the Greg k-h.

Don't wait for me, my queue is really long, if you have fixes that you
know you need to make, make them!

greg k-h