RE: [PATCH v2 1/2] Documentation: devicetree: Add DT bindings to xlnx_vcu driver

Dhaval Rajeshbhai Shah
2017-12-13T05:12:34Z

Hi Rob,

Thanks a lot for the review.

> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: Tuesday, December 12, 2017 12:07 PM
> To: Dhaval Rajeshbhai Shah <DSHAH@xilinx.com>
> Cc: arnd@arndb.de; gregkh@linuxfoundation.org;
> pombredanne@nexb.com; mark.rutland@arm.com;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> michal.simek@xilinx.com; Hyun Kwon <hyunk@xilinx.com>; Dhaval
> Rajeshbhai Shah <DSHAH@xilinx.com>
> Subject: Re: [PATCH v2 1/2] Documentation: devicetree: Add DT bindings to
> xlnx_vcu driver
>
> On Thu, Dec 07, 2017 at 01:31:15PM -0800, Dhaval Shah wrote:
> > Add Device Tree binding document for logicoreIP. This logicoreIP
> > provides the isolation between the processing system and programmable
> > logic. Also provides the clock related information.
> >
> > Signed-off-by: Dhaval Shah <dshah@xilinx.com>
> > ---
> > Changes since v2:
> > * Describe the h/w
> > * compatible string is updated to make it more specific
> > based on the logicoreIP version.
> > * Removed that encoder and decoder child nodes and relatd properties as
> that
> > will be a separate driver and dts nodes. other team is working on that.
> > * Updated to use as a single driver.
> >
> > .../devicetree/bindings/misc/xlnx,vcu.txt | 31
> ++++++++++++++++++++++
> > 1 file changed, 31 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/misc/xlnx,vcu.txt
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
> One nit. Use "dt-bindings: misc: ..." for the subject.
I will update subject line and send you v3 patch set.