RE: [PATCH] [linux][master][v1] misc: Add Xilinx ZYNQMP VCU logicoreIP init driver

Dhaval Rajeshbhai Shah
2017-12-06T09:06:01Z

> -----Original Message-----
> From: 'Greg KH' [mailto:gregkh@linuxfoundation.org]
> Sent: Tuesday, December 05, 2017 11:56 PM
> To: Dhaval Rajeshbhai Shah <DSHAH@xilinx.com>
> Cc: arnd@arndb.de; linux-kernel@vger.kernel.org; michal.simek@xilinx.com;
> Hyun Kwon <hyunk@xilinx.com>
> Subject: Re: [PATCH] [linux][master][v1] misc: Add Xilinx ZYNQMP VCU
> logicoreIP init driver
>
> On Wed, Dec 06, 2017 at 06:01:37AM +0000, Dhaval Rajeshbhai Shah wrote:
> > Hi Greg k-h,
> >
> > Thanks a lot for the review.
> >
> > Replies inline.
>
> As they should be, perhaps you need a better email client :)
>
> >
> > > +config XILINX_VCU
> > > + tristate "Xilinx VCU Init"
> > > + default n
> >
> > That's always the default, no need for this.
> > [Dhaval ] : I will remove that.
>
> This style of replying is very odd, please use the normal format in the future.
I have updated that in this reply.
>
> > > + help
> > > + Driver for the Xilinx VCU Init based on the logicoreIP.
> >
> > You need a lot more help text here to explain what this driver is, what it is
> for, and who would need it.
> > [Dhaval ] : I will provide more help text to provide more help on driver.
> >
> > Also, why is this a misc driver?
> > [Dhaval ] : this driver is for the logicoreIP which is created to support the
> Processing system and Programmable logic isolation and to provide the clock
> related information. So this is not a VCU driver and but just a intermediate
> driver which supports logicoreIP. That's why no subsystem for this.
>
> Then you need to explain this a lot better, posting a random driver for
> submission that is expected to be used by another one isn't ok.
> Post the whole patch series please, we do not add infrastructure to the
> kernel that is not used right then.
Can I remove the export api and header file and make this driver generic for the logicoreIP? No other driver will depend on that. This will help us to remove the isolation between the Programmable system and Programmable logic by configuring the logicoreIp register set.

Thanks
Dhaval
>
> thanks,
>
> greg k-h