From: Tejun Heo <tj@kernel.org>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Kirill Tkhai <ktkhai@virtuozzo.com>,
axboe@kernel.dk, bcrl@kvack.org, viro@zeniv.linux.org.uk,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-aio@kvack.org, oleg@redhat.com
Subject: Re: [PATCH 0/5] blkcg: Limit maximum number of aio requests available for cgroup
Date: Tue, 5 Dec 2017 07:51:25 -0800 [thread overview]
Message-ID: <20171205155125.GS2421075@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <x49vahl5giw.fsf@segfault.boston.devel.redhat.com>
Hello, Jeff.
On Tue, Dec 05, 2017 at 10:41:11AM -0500, Jeff Moyer wrote:
> Kirill Tkhai <ktkhai@virtuozzo.com> writes:
>
> >> I think you just need to account the completion ring.
> >
> > A request of struct aio_kiocb type consumes much more memory, than
> > struct io_event does. Shouldn't we account it too?
>
> Not in my opinion. The completion ring is the part that gets pinned for
> long periods of time.
For memcg, it should account all possibly significant memory
consumptions whether long term or transitional. Otherwise, isolation
doesn't really work that well.
> Just be sure to document this where appropriate. Users/admins should
> know that the aio completion ring now contributes to their memory
> budget.
Yeah, the memory section in cgroup-v2.txt does have a section for
this.
Thanks.
--
tejun
next prev parent reply other threads:[~2017-12-05 15:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 16:12 [PATCH 0/5] blkcg: Limit maximum number of aio requests available for cgroup Kirill Tkhai
2017-12-04 16:12 ` [PATCH 1/5] aio: Move aio_nr increment to separate function Kirill Tkhai
2017-12-04 16:13 ` [PATCH 2/5] aio: Export aio_nr_lock and aio_max_nr initial value to include/linux/aio.h Kirill Tkhai
2017-12-04 16:13 ` [PATCH 3/5] blkcg: Add blkcg::blkg_aio_nr and blkcg::blkg_aio_max_nr Kirill Tkhai
2017-12-04 16:13 ` [PATCH 4/5] blkcg: Charge aio requests in blkio cgroup hierarchy Kirill Tkhai
2017-12-04 16:13 ` [PATCH 5/5] blkcg: Add cgroup file to configure blkcg::blkg_aio_max_nr Kirill Tkhai
2017-12-04 16:52 ` [PATCH 0/5] blkcg: Limit maximum number of aio requests available for cgroup Benjamin LaHaise
2017-12-04 21:27 ` Kirill Tkhai
2017-12-04 21:35 ` Jeff Moyer
2017-12-04 21:48 ` Kirill Tkhai
2017-12-04 20:07 ` Tejun Heo
2017-12-04 21:44 ` Kirill Tkhai
2017-12-04 21:52 ` Tejun Heo
2017-12-04 22:49 ` Kirill Tkhai
2017-12-04 22:59 ` Jeff Moyer
2017-12-04 23:14 ` Kirill Tkhai
2017-12-05 15:41 ` Jeff Moyer
2017-12-05 15:51 ` Tejun Heo [this message]
2017-12-04 23:02 ` Tejun Heo
2017-12-04 23:05 ` Kirill Tkhai
2017-12-05 15:19 ` Oleg Nesterov
2017-12-05 15:35 ` Benjamin LaHaise
2017-12-06 17:32 ` Oleg Nesterov
2017-12-06 17:44 ` Benjamin LaHaise
2017-12-06 18:19 ` Kirill Tkhai
2017-12-06 18:30 ` Benjamin LaHaise
2017-12-06 19:37 ` Kirill Tkhai
2017-12-07 13:44 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205155125.GS2421075@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=bcrl@kvack.org \
--cc=jmoyer@redhat.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-aio@kvack.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox