From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753020AbdLER2F (ORCPT ); Tue, 5 Dec 2017 12:28:05 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:37187 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752980AbdLER2D (ORCPT ); Tue, 5 Dec 2017 12:28:03 -0500 X-ME-Sender: Date: Tue, 5 Dec 2017 18:28:11 +0100 From: Greg KH To: Guenter Roeck Cc: benjamin.gaignard@linaro.org, lee.jones@linaro.org, alexandre.torgue@st.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Benjamin Gaignard Subject: Re: [v2] mfd: stm32: Adopt SPDX identifier Message-ID: <20171205172811.GA5534@kroah.com> References: <20171205152418.28104-1-benjamin.gaignard@st.com> <20171205172337.GA24480@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171205172337.GA24480@roeck-us.net> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 05, 2017 at 09:23:37AM -0800, Guenter Roeck wrote: > On Tue, Dec 05, 2017 at 04:24:18PM +0100, benjamin.gaignard@linaro.org wrote: > > Add SPDX identifier > > > > Signed-off-by: Benjamin Gaignard > > --- > > drivers/mfd/stm32-lptimer.c | 6 +----- > > drivers/mfd/stm32-timers.c | 4 +--- > > include/linux/mfd/stm32-lptimer.h | 6 +----- > > include/linux/mfd/stm32-timers.h | 4 +--- > > 4 files changed, 4 insertions(+), 16 deletions(-) > > > > diff --git a/drivers/mfd/stm32-lptimer.c b/drivers/mfd/stm32-lptimer.c > > index 075330a25f61..a00f99f36559 100644 > > --- a/drivers/mfd/stm32-lptimer.c > > +++ b/drivers/mfd/stm32-lptimer.c > > @@ -1,13 +1,9 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > /* > > I have been wondering - why is the SPDX identifier for the most part added > as separate C++ comment at the beginning of the file, and not inline with > the rest of the top comments ? SPDX doesn't mandate this - the examples > I can find on the SPDX web site all show it inline. Is there a special > Linux kernel convention ? See the patch series from Thomas that answers this question for you by adding documentation to the kernel explaining it all :) thanks, greg k-h