From: Guenter Roeck <linux@roeck-us.net>
To: Greg KH <greg@kroah.com>
Cc: benjamin.gaignard@linaro.org, lee.jones@linaro.org,
alexandre.torgue@st.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Benjamin Gaignard <benjamin.gaignard@st.com>
Subject: Re: [v2] mfd: stm32: Adopt SPDX identifier
Date: Tue, 5 Dec 2017 10:07:13 -0800 [thread overview]
Message-ID: <20171205180713.GA25739@roeck-us.net> (raw)
In-Reply-To: <20171205172811.GA5534@kroah.com>
On Tue, Dec 05, 2017 at 06:28:11PM +0100, Greg KH wrote:
> On Tue, Dec 05, 2017 at 09:23:37AM -0800, Guenter Roeck wrote:
> > On Tue, Dec 05, 2017 at 04:24:18PM +0100, benjamin.gaignard@linaro.org wrote:
> > > Add SPDX identifier
> > >
> > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> > > ---
> > > drivers/mfd/stm32-lptimer.c | 6 +-----
> > > drivers/mfd/stm32-timers.c | 4 +---
> > > include/linux/mfd/stm32-lptimer.h | 6 +-----
> > > include/linux/mfd/stm32-timers.h | 4 +---
> > > 4 files changed, 4 insertions(+), 16 deletions(-)
> > >
> > > diff --git a/drivers/mfd/stm32-lptimer.c b/drivers/mfd/stm32-lptimer.c
> > > index 075330a25f61..a00f99f36559 100644
> > > --- a/drivers/mfd/stm32-lptimer.c
> > > +++ b/drivers/mfd/stm32-lptimer.c
> > > @@ -1,13 +1,9 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > /*
> >
> > I have been wondering - why is the SPDX identifier for the most part added
> > as separate C++ comment at the beginning of the file, and not inline with
> > the rest of the top comments ? SPDX doesn't mandate this - the examples
> > I can find on the SPDX web site all show it inline. Is there a special
> > Linux kernel convention ?
>
> See the patch series from Thomas that answers this question for you by
> adding documentation to the kernel explaining it all :)
>
So it is a special Linux kernel convention. Interesting (and brrr ... :-)
Thanks for the clarification.
Guenter
next prev parent reply other threads:[~2017-12-05 18:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 15:24 [PATCH v2] mfd: stm32: Adopt SPDX identifier Benjamin Gaignard
2017-12-05 17:23 ` [v2] " Guenter Roeck
2017-12-05 17:28 ` Greg KH
2017-12-05 18:07 ` Guenter Roeck [this message]
2017-12-07 10:36 ` [PATCH v2] " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205180713.GA25739@roeck-us.net \
--to=linux@roeck-us.net \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=benjamin.gaignard@st.com \
--cc=greg@kroah.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox