From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753146AbdLESPu (ORCPT ); Tue, 5 Dec 2017 13:15:50 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:47812 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753119AbdLESPr (ORCPT ); Tue, 5 Dec 2017 13:15:47 -0500 Date: Tue, 5 Dec 2017 19:15:34 +0100 From: Heiko Carstens To: Greg Kroah-Hartman Cc: Ben Hutchings , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Christian Borntraeger , Martin Schwidefsky Subject: Re: [PATCH 4.4 02/96] s390/runtime instrumention: fix possible memory corruption References: <20171128100503.067621614@linuxfoundation.org> <20171128100503.204142514@linuxfoundation.org> <1512493352.18523.180.camel@codethink.co.uk> <20171205170847.GA22747@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171205170847.GA22747@kroah.com> X-TM-AS-GCONF: 00 x-cbid: 17120518-0040-0000-0000-00000416AC30 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17120518-0041-0000-0000-000020B9A457 Message-Id: <20171205181534.GA3092@osiris> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-05_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712050262 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 05, 2017 at 06:08:47PM +0100, Greg Kroah-Hartman wrote: > On Tue, Dec 05, 2017 at 05:02:32PM +0000, Ben Hutchings wrote: > > On Tue, 2017-11-28 at 11:22 +0100, Greg Kroah-Hartman wrote: > > > 4.4-stable review patch.  If anyone has any objections, please let me know. > > > > > > ------------------ > > > > > > From: Heiko Carstens > > > > > > commit d6e646ad7cfa7034d280459b2b2546288f247144 upstream. > > [...] > > > --- a/arch/s390/kernel/runtime_instr.c > > > +++ b/arch/s390/kernel/runtime_instr.c > > > @@ -47,11 +47,13 @@ void exit_thread_runtime_instr(void) > > >  { > > >   struct task_struct *task = current; > > >   > > > + preempt_disable(); > > >   if (!task->thread.ri_cb) > > >   return; > > > > This return path now leaves preemption disabled. This seems to have > > been fixed upstream by commit 8d9047f8b967 "s390/runtime > > instrumentation: simplify task exit handling". > > "simplify" doesn't seem to imply "fixes a bug" :) Indeed ;) That where two subsequent patches, but incorrectly split by me... > Heiko, should I also queue this patch up? Yes, please. > thanks Ben for the review. Thanks from me as well!