Re: [PATCH v2 01/15] NTB: Rename NTB messaging API methods

Logan Gunthorpe
2017-12-05T21:48:53Z

On 05/12/17 01:54 PM, Serge Semin wrote:

>> Just because no one said anything before, doesn't mean it's
>> acceptable. I think that is the official Linux code review mantra ;-)
>>
>> Okay, if we are going to do it this way, then return ~0 instead. At
>> least that way there is no ugly cast.
>>
>
> Ok. I'll replace it with ~(u32)0.

That's exactly the same just more confusing. I'm still in favor of
leaving it the way it was.

Logan