From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752079AbdLEU1a (ORCPT <rfc822;w@1wt.eu>);
        Tue, 5 Dec 2017 15:27:30 -0500
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:45491 "EHLO
        out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751463AbdLEU10 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 5 Dec 2017 15:27:26 -0500
X-ME-Sender: <xms:LQEnWnp6L-bcLoHg64ZIxnB9zlA3ig-vVKB4dGJw2kL48KYpZ2YmIQ>
Date: Wed, 6 Dec 2017 07:27:21 +1100
From: "Tobin C. Harding" <me@tobin.cc>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Andy Whitcroft <apw@canonical.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: warn for use of %px
Message-ID: <20171205202721.GC11064@eros>
References: <1512422224-29827-1-git-send-email-me@tobin.cc>
 <1512458664.6321.71.camel@perches.com>
 <20171205094432.GA11064@eros>
 <1512487638.6321.80.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1512487638.6321.80.camel@perches.com>
X-Mailer: Mutt 1.5.24 (2015-08-30)
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Dec 05, 2017 at 07:27:18AM -0800, Joe Perches wrote:
> On Tue, 2017-12-05 at 20:44 +1100, Tobin C. Harding wrote:
> > On Mon, Dec 04, 2017 at 11:24:24PM -0800, Joe Perches wrote:
> > > On Tue, 2017-12-05 at 08:17 +1100, Tobin C. Harding wrote:
> > > > Usage of the new %px specifier potentially leaks sensitive
> > > > inforamtion. Printing kernel addresses exposes the kernel layout in
> > > 
> > > information
> 
> > I don't understand this comment? Do you mean the wording is wrong?
> > I'll re-word as suggested below.
> 
> It's just a spelling typo correction.

ha ha, note to self - be careful doing kernel email late at night :)

> []
> > > > Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> > > > Signed-off-by: Tobin C. Harding <me@tobin.cc>
> > > > Co-Developed-by: Joe Perches <joe@perches.com>
> > > > Are you happy with this tagging? Needs your signed-off-by still.
> 
> I think signatures tags are pretty freeform and
> I'm not particularly concerned about them.
> 
> I think Andrew Morton may object and change it
> or remove it.  Have an:
> 
> Acked-by: Joe Perches <joe@perches.com>

Cool, will add and re-spin

thanks,
Tobin.