From: "Simon Sandström" <simon@nikanor.nu>
To: gregkh@linuxfoundation.org
Cc: linux@Wolf-Entwicklungen.de, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 00/11] Fix indentation and CamelCase issue in staging/pi433
Date: Tue, 5 Dec 2017 23:08:38 +0100 [thread overview]
Message-ID: <20171205220849.5486-1-simon@nikanor.nu> (raw)
These patches fixes a bunch of code style issues in staging/pi433. The first
patch fixes indentation in rf69_enum.h and the rest of the patches fixes
CamelCase issues and other minor issues in all of staging/pi433.
Changes in v2:
- Instead of fixing CamelCase issue in enum data_mode, remove it
completely.
- Split multiple functions of type
"rf69_set_x_enabled(dev, enum option_on_off)" to two functions:
"rf69_enable_x(dev)" and "rf69_disable_x(dev)".
- Move enum option_on_off to pi433_if.h as it's now only used for
ioctl.
- Fix issue where GPIOs and device not being deallocated in
pi433_probe() if SET_CHECKED fails.
- Simon
---
Simon Sandström (11):
staging: pi433: Fix indentation in rf69_enum.h
staging: pi433: Capitalize constant definitions
staging: pi433: Rename variable in struct pi433_rx_cfg
staging: pi433: Rename enum optionOnOff in rf69_enum.h
staging: pi433: Rename enum modShaping in rf69_enum.h
staging: pi433: Split rf69_set_crc_enabled into two functions
staging: pi433: Split rf69_set_sync_enabled into two functions
staging: pi433: Remove enum data_mode
staging: pi433: Combine all rf69_set_amplifier_x()
staging: pi433: Move enum option_on_off to pi433_if.h
staging: pi433: Remove SET_CHECKED usage from pi433_probe
drivers/staging/pi433/pi433_if.c | 135 ++++++++++++++-------
drivers/staging/pi433/pi433_if.h | 25 ++--
drivers/staging/pi433/rf69.c | 113 +++++-------------
drivers/staging/pi433/rf69.h | 15 +--
drivers/staging/pi433/rf69_enum.h | 210 ++++++++++++++++-----------------
drivers/staging/pi433/rf69_registers.h | 44 +++----
6 files changed, 265 insertions(+), 277 deletions(-)
--
2.11.0
next reply other threads:[~2017-12-05 22:08 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 22:08 Simon Sandström [this message]
2017-12-05 22:08 ` [PATCH v2 01/11] staging: pi433: Fix indentation in rf69_enum.h Simon Sandström
2017-12-05 22:08 ` [PATCH v2 02/11] staging: pi433: Capitalize constant definitions Simon Sandström
2017-12-05 22:08 ` [PATCH v2 03/11] staging: pi433: Rename variable in struct pi433_rx_cfg Simon Sandström
2017-12-05 22:08 ` [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h Simon Sandström
2017-12-06 9:46 ` Marcus Wolf
2017-12-06 10:23 ` Dan Carpenter
2017-12-06 10:31 ` Marcus Wolf
2017-12-06 10:44 ` Dan Carpenter
2017-12-06 11:07 ` Marcus Wolf
2017-12-06 19:57 ` Simon Sandström
2017-12-06 22:17 ` Marcus Wolf
2017-12-07 9:41 ` Dan Carpenter
2017-12-05 22:08 ` [PATCH v2 05/11] staging: pi433: Rename enum modShaping " Simon Sandström
2017-12-05 22:08 ` [PATCH v2 06/11] staging: pi433: Split rf69_set_crc_enabled into two functions Simon Sandström
2017-12-06 9:05 ` Marcus Wolf
2017-12-06 9:37 ` Dan Carpenter
2017-12-06 10:07 ` Marcus Wolf
2017-12-06 15:11 ` Greg KH
2017-12-06 10:36 ` Marcus Wolf
2017-12-06 15:16 ` Greg KH
2017-12-06 20:27 ` Simon Sandström
2017-12-05 22:08 ` [PATCH v2 07/11] staging: pi433: Split rf69_set_sync_enabled " Simon Sandström
2017-12-05 22:08 ` [PATCH v2 08/11] staging: pi433: Remove enum data_mode Simon Sandström
2017-12-06 9:11 ` Marcus Wolf
2017-12-06 12:47 ` Dan Carpenter
2017-12-07 9:47 ` staging: pi433: Plans from Smarthome-Wolf Marcus Wolf
2017-12-05 22:08 ` [PATCH v2 09/11] staging: pi433: Combine all rf69_set_amplifier_x() Simon Sandström
2017-12-06 9:43 ` Marcus Wolf
2017-12-05 22:08 ` [PATCH v2 10/11] staging: pi433: Move enum option_on_off to pi433_if.h Simon Sandström
2017-12-05 22:08 ` [PATCH v2 11/11] staging: pi433: Remove SET_CHECKED usage from pi433_probe Simon Sandström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205220849.5486-1-simon@nikanor.nu \
--to=simon@nikanor.nu \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@Wolf-Entwicklungen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox