From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752970AbdLFGat (ORCPT ); Wed, 6 Dec 2017 01:30:49 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:49062 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752519AbdLFGaq (ORCPT ); Wed, 6 Dec 2017 01:30:46 -0500 Date: Wed, 6 Dec 2017 07:30:52 +0100 From: Greg Kroah-Hartman To: "Tobin C. Harding" Cc: Matt Fleming , Ard Biesheuvel , Dave Young , Linus Torvalds , LKML , "linux-efi@vger.kernel.org" Subject: Re: [PATCH] efi: move some sysfs files to be read-only by root Message-ID: <20171206063052.GC20995@kroah.com> References: <20171205101343.GA5416@kroah.com> <20171205205041.GE11064@eros> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171205205041.GE11064@eros> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 06, 2017 at 07:50:41AM +1100, Tobin C. Harding wrote: > On Tue, Dec 05, 2017 at 11:13:43AM +0100, Greg Kroah-Hartman wrote: > > Thanks to the scripts/leaking_addresses.pl script, it was found that > > some EFI values should not be readable by non-root users. > > > > So make them root-only, and to do that, add a __ATTR_RO_MODE() macro to > > make this easier, and use it in other places at the same time. > > > > Reported-by: Linus Torvalds > > Tested-by: Dave Young > > Cc: Matt Fleming > > Cc: Ard Biesheuvel > > Cc: stable > > Signed-off-by: Greg Kroah-Hartman > > > > --- > > drivers/firmware/efi/efi.c | 3 +-- > > drivers/firmware/efi/esrt.c | 15 ++++++--------- > > drivers/firmware/efi/runtime-map.c | 10 +++++----- > > include/linux/sysfs.h | 5 +++++ > > 4 files changed, 17 insertions(+), 16 deletions(-) > > > > --- a/drivers/firmware/efi/efi.c > > +++ b/drivers/firmware/efi/efi.c > > @@ -143,8 +143,7 @@ static ssize_t systab_show(struct kobjec > > return str - buf; > > } > > Greg, do you add the CC's here in the commit log for a technical reason? > Is it so that future investigation that leads to this commit can see who > to involve in any further discussion? They came from the output of scripts/get_maintainer.pl on who I should be sending the patch to, and who should hopefully review it. > As an example, for the patch that added the %p hashing should I have > CC'd Jason A. Donenfeld since he was the brains behind the SipHash > stuff and gave loads of suggestions/direction? If you want to. It's also a good way for me to track who the patch gets sent to when doing multiple versions of a patch series. git send-email picks those up and sends the patch to them as well, making it easier on the developer instead of having to remember a long --cc= list of addresses. thanks, greg k-h