* [PATCH 1/1] mtd: nand: brcmnand: Zero bitflip is not an error
@ 2017-11-20 3:26 Albert Hsieh
2017-12-06 9:16 ` Boris Brezillon
0 siblings, 1 reply; 2+ messages in thread
From: Albert Hsieh @ 2017-11-20 3:26 UTC (permalink / raw)
To: computersforpeace
Cc: kdasu.kdev, boris.brezillon, richard, dwmw2, marek.vasut,
cyrille.pitchen, linux-mtd, bcm-kernel-feedback-list,
linux-kernel, hsiehwt, Albert Hsieh
A negative return value of brcmstb_nand_verify_erased_page() indicates a
real bitflip error of an erased page, and other return values (>= 0) show
the corrected bitflip number. Zero return value means no bitflip, but the
current driver code treats it as an error, and eventually leads to
falsely reported ECC error.
Fixes: 02b88eea9f9c ("mtd: brcmnand: Add check for erased page bitflip")
Signed-off-by: Albert Hsieh <wen.hsieh@broadcom.com>
---
drivers/mtd/nand/brcmnand/brcmnand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/brcmnand/brcmnand.c b/drivers/mtd/nand/brcmnand/brcmnand.c
index e0eb51d..dd56a67 100644
--- a/drivers/mtd/nand/brcmnand/brcmnand.c
+++ b/drivers/mtd/nand/brcmnand/brcmnand.c
@@ -1763,7 +1763,7 @@ static int brcmnand_read(struct mtd_info *mtd, struct nand_chip *chip,
err = brcmstb_nand_verify_erased_page(mtd, chip, buf,
addr);
/* erased page bitflips corrected */
- if (err > 0)
+ if (err >= 0)
return err;
}
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] mtd: nand: brcmnand: Zero bitflip is not an error
2017-11-20 3:26 [PATCH 1/1] mtd: nand: brcmnand: Zero bitflip is not an error Albert Hsieh
@ 2017-12-06 9:16 ` Boris Brezillon
0 siblings, 0 replies; 2+ messages in thread
From: Boris Brezillon @ 2017-12-06 9:16 UTC (permalink / raw)
To: Albert Hsieh, richard
Cc: computersforpeace, hsiehwt, kdasu.kdev, linux-kernel, marek.vasut,
linux-mtd, cyrille.pitchen, bcm-kernel-feedback-list, dwmw2
On Mon, 20 Nov 2017 11:26:26 +0800
Albert Hsieh <wen.hsieh@broadcom.com> wrote:
> A negative return value of brcmstb_nand_verify_erased_page() indicates a
> real bitflip error of an erased page, and other return values (>= 0) show
> the corrected bitflip number. Zero return value means no bitflip, but the
> current driver code treats it as an error, and eventually leads to
> falsely reported ECC error.
>
> Fixes: 02b88eea9f9c ("mtd: brcmnand: Add check for erased page bitflip")
> Signed-off-by: Albert Hsieh <wen.hsieh@broadcom.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: <stable@vger.kernel.org>
Richard, can you queue this patch to the mtd/master branch?
Thanks,
Boris
> ---
> drivers/mtd/nand/brcmnand/brcmnand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/brcmnand/brcmnand.c b/drivers/mtd/nand/brcmnand/brcmnand.c
> index e0eb51d..dd56a67 100644
> --- a/drivers/mtd/nand/brcmnand/brcmnand.c
> +++ b/drivers/mtd/nand/brcmnand/brcmnand.c
> @@ -1763,7 +1763,7 @@ static int brcmnand_read(struct mtd_info *mtd, struct nand_chip *chip,
> err = brcmstb_nand_verify_erased_page(mtd, chip, buf,
> addr);
> /* erased page bitflips corrected */
> - if (err > 0)
> + if (err >= 0)
> return err;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-06 9:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-20 3:26 [PATCH 1/1] mtd: nand: brcmnand: Zero bitflip is not an error Albert Hsieh
2017-12-06 9:16 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox