public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
	"maintainer:X86" <x86@kernel.org>,
	Mike Travis <mike.travis@hpe.com>,
	Russ Anderson <russ.anderson@hpe.com>,
	"travis @ sgi . com" <travis@sgi.com>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/platform/UV: make functions uv_handle_nmi and uv_nmi_setup_common static
Date: Wed, 6 Dec 2017 18:15:15 +0100	[thread overview]
Message-ID: <20171206171515.c6phtllfdw7nfbix@gmail.com> (raw)
In-Reply-To: <20171206170828.23524-1-colin.king@canonical.com>


* Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> Functions uv_handle_nmi and uv_nmi_setup_common are local to the
> source and do not need to be in global scope, so make them static.
> 
> Cleans up sparse warnings:
> symbol 'uv_handle_nmi' was not declared. Should it be static?
> symbol 'uv_nmi_setup_common' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  arch/x86/platform/uv/uv_nmi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Please combine your three pending x86 Sparse fix patches (this one, the x86/vector 
one and the x86/mm one) into a single patch. They are trivial and should not be 
split into 3 patches.

Thanks,

	Ingo

  reply	other threads:[~2017-12-06 17:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-06 17:08 [PATCH] x86/platform/UV: make functions uv_handle_nmi and uv_nmi_setup_common static Colin King
2017-12-06 17:15 ` Ingo Molnar [this message]
2017-12-06 17:38 ` Mike Travis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171206171515.c6phtllfdw7nfbix@gmail.com \
    --to=mingo@kernel.org \
    --cc=colin.king@canonical.com \
    --cc=hpa@zytor.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.travis@hpe.com \
    --cc=mingo@redhat.com \
    --cc=russ.anderson@hpe.com \
    --cc=tglx@linutronix.de \
    --cc=travis@sgi.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox