From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752642AbdLFRPU (ORCPT ); Wed, 6 Dec 2017 12:15:20 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:34239 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752303AbdLFRPT (ORCPT ); Wed, 6 Dec 2017 12:15:19 -0500 X-Google-Smtp-Source: AGs4zMZDzKqritz0HPpCjLMbVQ5CRcvdSNn2pmk0F2LlfxP48gyRwhXnXd9pBBla4cjYdhsB6Lmq0A== Date: Wed, 6 Dec 2017 18:15:15 +0100 From: Ingo Molnar To: Colin King Cc: Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , "maintainer:X86" , Mike Travis , Russ Anderson , "travis @ sgi . com" , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/platform/UV: make functions uv_handle_nmi and uv_nmi_setup_common static Message-ID: <20171206171515.c6phtllfdw7nfbix@gmail.com> References: <20171206170828.23524-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171206170828.23524-1-colin.king@canonical.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Colin King wrote: > From: Colin Ian King > > Functions uv_handle_nmi and uv_nmi_setup_common are local to the > source and do not need to be in global scope, so make them static. > > Cleans up sparse warnings: > symbol 'uv_handle_nmi' was not declared. Should it be static? > symbol 'uv_nmi_setup_common' was not declared. Should it be static? > > Signed-off-by: Colin Ian King > --- > arch/x86/platform/uv/uv_nmi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Please combine your three pending x86 Sparse fix patches (this one, the x86/vector one and the x86/mm one) into a single patch. They are trivial and should not be split into 3 patches. Thanks, Ingo