From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752487AbdLFWEk (ORCPT ); Wed, 6 Dec 2017 17:04:40 -0500 Received: from muru.com ([72.249.23.125]:53902 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752433AbdLFWEj (ORCPT ); Wed, 6 Dec 2017 17:04:39 -0500 Date: Wed, 6 Dec 2017 14:04:36 -0800 From: Tony Lindgren To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ARM: omap2: hide omap3_save_secure_ram on non-OMAP3 builds Message-ID: <20171206220436.GA28152@atomide.com> References: <20171206214916.2856657-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171206214916.2856657-1-arnd@arndb.de> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Arnd Bergmann [171206 21:52]: > In configurations without CONFIG_OMAP3 but with secure RAM support, > we now run into a link failure: > > arch/arm/mach-omap2/omap-secure.o: In function `omap3_save_secure_ram': > omap-secure.c:(.text+0x130): undefined reference to `save_secure_ram_context' > > The omap3_save_secure_ram() function is only called from the OMAP34xx > power management code, so we can simply hide that function in the > appropriate #ifdef. > > Fixes: d09220a887f7 ("ARM: OMAP2+: Fix SRAM virt to phys translation for save_secure_ram_context") > Signed-off-by: Arnd Bergmann > --- > v2: also check for CONFIG_PM Acked-by: Tony Lindgren