From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750922AbdLGGzt (ORCPT ); Thu, 7 Dec 2017 01:55:49 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:59942 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750781AbdLGGzs (ORCPT ); Thu, 7 Dec 2017 01:55:48 -0500 Date: Thu, 7 Dec 2017 07:55:54 +0100 From: Greg Kroah-Hartman To: Joe Perches Cc: "Tobin C. Harding" , Andy Whitcroft , Andrew Morton , linux-kernel@vger.kernel.org, Thomas Gleixner , Borislav Petkov , Jonathan Corbet Subject: Re: [PATCH] checkpatch: add check for tag Co-Developed-by Message-ID: <20171207065554.GA19722@kroah.com> References: <1512608376-4234-1-git-send-email-me@tobin.cc> <1512628466.960.30.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1512628466.960.30.camel@perches.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 06, 2017 at 10:34:26PM -0800, Joe Perches wrote: > On Thu, 2017-12-07 at 11:59 +1100, Tobin C. Harding wrote: > > Recently signature tag Co-Developed-by was added to the > > kernel (Documentation/process/5.Posting.rst). checkpatch.pl doesn't know > > about it yet. All prior tags used all lowercase characters except for first > > character. Checks for this format had to be re-worked to allow for the > > new tag. > > > > Add checkpatch checks for Co-Developed-by tag. > [] > > +++ b/scripts/checkpatch.pl > > @@ -468,6 +468,7 @@ our $signature_tags = qr{(?xi: > > Reviewed-by:| > > Reported-by:| > > Suggested-by:| > > + Co-Developed-by:| > > I think the extra hyphenate form is poor at best. > Codeveloped-by: should be the only form. That's not what Documentation/process/5.Posting.rst says, sorry. So Tobin's patch is correct. thanks, greg k-h