Re: [PATCH v6 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

Brian Norris
2017-12-07T17:24:35Z

On Thu, Dec 07, 2017 at 11:41:17AM +0000, Philippe CORNU wrote:
> platform_set_drvdata() is still missing in your version.

Ugh...indeed.

> On 12/06/2017 10:39 PM, Brian Norris wrote:
> > On Wed, Dec 06, 2017 at 05:08:19PM +0800, Nickey Yang wrote:
> >> From: Brian Norris <briannorris@chromium.org>
> >>
> >> Bridge drivers/helpers shouldn't be clobbering the drvdata, since a
> >> parent driver might need to own this. Instead, let's return our
> >> 'dw_mipi_dsi' object and have callers pass that back to us for removal.
> >>
> >> Signed-off-by: Brian Norris <briannorris@chromium.org>
> >> Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
> >> Link:https://patchwork.kernel.org/patch/10078493/
> >>
> >> ---
> >> Changes
> >>
> >> v4:
> >> - Add From tag,update subject line
> >> - keep patch "drm/stm: dsi: Adjust dw_mipi_dsi_probe and remove"
> >> in this piece together.
> >>
> >> v5:
> >> - remove Review & Ack tag
> >> - fix remove() directly referencing the static
> >> dw_mipi_dsi_stm_plat_data struct.
> >
> > You've gotten this back into basically the shape I sent v1 in, so I
> > guess this deserves an:
> >
> > Acked-by: Brian Norris <briannorris@chromium.org>

...and I even diffed the two directly and didn't notice that one missing
at first :(

So instead, make that:

Nacked-by: Brian Norris <briannorris@chromium.org>

Can you *please* just use my patch and reword the commit message/subject
per the original comments on version 1? You're screwing it up every time
you try to change it...