From: "Tobin C. Harding" <me@tobin.cc>
To: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] checkpatch: add check for tag Co-Developed-by
Date: Fri, 8 Dec 2017 07:56:17 +1100 [thread overview]
Message-ID: <20171207205617.GJ2191@eros> (raw)
In-Reply-To: <1512664018.960.45.camel@perches.com>
On Thu, Dec 07, 2017 at 08:26:58AM -0800, Joe Perches wrote:
> On Thu, 2017-12-07 at 11:59 +1100, Tobin C. Harding wrote:
> > Recently signature tag Co-Developed-by was added to the
> > kernel (Documentation/process/5.Posting.rst). checkpatch.pl doesn't know
> > about it yet. All prior tags used all lowercase characters except for first
> > character. Checks for this format had to be re-worked to allow for the
> > new tag.
> >
> > Add checkpatch checks for Co-Developed-by tag.
>
> This patch is not extensible.
>
> If this is to be done at all, the Co-Developed-by:
> should not be a special case because a new and
> different one might be added in the future.
I agree, fixing individual corner cases is bad style.
> Better to verify that a case insensitive match exists
> in $signature_tags and then complain if the match is
> not exact.
I'll have a go at this.
thanks,
Tobin.
prev parent reply other threads:[~2017-12-07 20:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 0:59 [PATCH] checkpatch: add check for tag Co-Developed-by Tobin C. Harding
2017-12-07 6:34 ` Joe Perches
2017-12-07 6:55 ` Greg Kroah-Hartman
2017-12-07 6:59 ` Joe Perches
2017-12-07 6:56 ` Greg Kroah-Hartman
2017-12-07 16:26 ` Joe Perches
2017-12-07 20:56 ` Tobin C. Harding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171207205617.GJ2191@eros \
--to=me@tobin.cc \
--cc=apw@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox