From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752851AbdLGU4X (ORCPT ); Thu, 7 Dec 2017 15:56:23 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:47799 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750929AbdLGU4V (ORCPT ); Thu, 7 Dec 2017 15:56:21 -0500 X-ME-Sender: Date: Fri, 8 Dec 2017 07:56:17 +1100 From: "Tobin C. Harding" To: Joe Perches Cc: Andy Whitcroft , linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH] checkpatch: add check for tag Co-Developed-by Message-ID: <20171207205617.GJ2191@eros> References: <1512608376-4234-1-git-send-email-me@tobin.cc> <1512664018.960.45.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1512664018.960.45.camel@perches.com> X-Mailer: Mutt 1.5.24 (2015-08-30) User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 07, 2017 at 08:26:58AM -0800, Joe Perches wrote: > On Thu, 2017-12-07 at 11:59 +1100, Tobin C. Harding wrote: > > Recently signature tag Co-Developed-by was added to the > > kernel (Documentation/process/5.Posting.rst). checkpatch.pl doesn't know > > about it yet. All prior tags used all lowercase characters except for first > > character. Checks for this format had to be re-worked to allow for the > > new tag. > > > > Add checkpatch checks for Co-Developed-by tag. > > This patch is not extensible. > > If this is to be done at all, the Co-Developed-by: > should not be a special case because a new and > different one might be added in the future. I agree, fixing individual corner cases is bad style. > Better to verify that a case insensitive match exists > in $signature_tags and then complain if the match is > not exact. I'll have a go at this. thanks, Tobin.