Re: [PATCH] checkpatch: add check for tag Co-Developed-by

Joe Perches
2017-12-07T06:59:28Z

On Thu, 2017-12-07 at 07:55 +0100, Greg Kroah-Hartman wrote:
> On Wed, Dec 06, 2017 at 10:34:26PM -0800, Joe Perches wrote:
> > On Thu, 2017-12-07 at 11:59 +1100, Tobin C. Harding wrote:
> > > Recently signature tag Co-Developed-by was added to the
> > > kernel (Documentation/process/5.Posting.rst). checkpatch.pl doesn't know
> > > about it yet. All prior tags used all lowercase characters except for first
> > > character. Checks for this format had to be re-worked to allow for the
> > > new tag.
> > >
> > > Add checkpatch checks for Co-Developed-by tag.
> >
> > []
> > > +++ b/scripts/checkpatch.pl
> > > @@ -468,6 +468,7 @@ our $signature_tags = qr{(?xi:
> > > Reviewed-by:|
> > > Reported-by:|
> > > Suggested-by:|
> > > + Co-Developed-by:|
> >
> > I think the extra hyphenate form is poor at best.
> > Codeveloped-by: should be the only form.
>
> That's not what Documentation/process/5.Posting.rst says, sorry.

So what? That's easy to change.

> So Tobin's patch is correct.

Not to me.